-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update of default eta value using empirical high trigger rate data #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gh trigger rate data
samaloney
approved these changes
Oct 18, 2023
1 task
grazwegian
added a commit
to grazwegian/STIX-GSW
that referenced
this pull request
Oct 30, 2023
* i4ds: Initial release of basic routines for downloading L2 AUX ephemeris files given a date and L1 science data fits files given a UID. (i4Ds#189) Fixed bug in the estimation of the total number of bkg counts (i4Ds#186) stx_livetime_fraction: update of default eta value using empirical high trigger rate data (i4Ds#188) Energy calibration improvement (i4Ds#183) Call lightcurve without generating FITS files (i4Ds#181) Respect shift_duration if file is "possibly summed on board". (i4Ds#180) Clarify flare_location coordinates (i4Ds#169) # Conflicts: # stix/dbase/detector/elut_index.csv
grazwegian
added a commit
to grazwegian/STIX-GSW
that referenced
this pull request
Nov 2, 2023
* i4ds: Initial release of basic routines for downloading L2 AUX ephemeris files given a date and L1 science data fits files given a UID. (i4Ds#189) Fixed bug in the estimation of the total number of bkg counts (i4Ds#186) stx_livetime_fraction: update of default eta value using empirical high trigger rate data (i4Ds#188) Energy calibration improvement (i4Ds#183) Call lightcurve without generating FITS files (i4Ds#181) Respect shift_duration if file is "possibly summed on board". (i4Ds#180) Clarify flare_location coordinates (i4Ds#169) # Conflicts: # stix/dbase/detector/elut_index.csv # stix/dbase/detector/science_echan_index.csv # stix/idl/demo/stx_ospex_spectroscopy_demo.pro # stix/idl/processing/spectrogram/stx_convert_pixel_data.pro # stix/idl/processing/spectrogram/stx_convert_science_data2ospex.pro # stix/idl/processing/spectrogram/stx_convert_spectrogram.pro # stix/idl/processing/spectrogram/stx_fsw_sd_spectrogram2ospex.pro # stix/idl/processing/spectrogram/stx_science_data_lightcurve.pro
grazwegian
added a commit
to grazwegian/STIX-GSW
that referenced
this pull request
Nov 22, 2023
* i4ds: Initial release of basic routines for downloading L2 AUX ephemeris files given a date and L1 science data fits files given a UID. (i4Ds#189) Fixed bug in the estimation of the total number of bkg counts (i4Ds#186) stx_livetime_fraction: update of default eta value using empirical high trigger rate data (i4Ds#188) Energy calibration improvement (i4Ds#183) Call lightcurve without generating FITS files (i4Ds#181) Respect shift_duration if file is "possibly summed on board". (i4Ds#180) Clarify flare_location coordinates (i4Ds#169) # Conflicts: # stix/dbase/detector/elut_index.csv
grazwegian
added a commit
to grazwegian/STIX-GSW
that referenced
this pull request
Dec 14, 2023
* i4ds: (28 commits) Bugfix release stx_read_fits : uncommented call to mrdfits to prevent compilation issue when getting version number preparing a new release Fixed bug in selection of energy indices of pixel data matrix (i4Ds#185) stx_subc_transmission: Improved accuracy of message displayed if simple_transm keyword is set. Update by Massa, P. - use simplified version of the subcollimator transmission for imaging (temporary solution) Some Improvement in aspect processing (i4Ds#179) Initial release of basic routines for downloading L2 AUX ephemeris files given a date and L1 science data fits files given a UID. (i4Ds#189) Fixed bug in the estimation of the total number of bkg counts (i4Ds#186) stx_livetime_fraction: update of default eta value using empirical high trigger rate data (i4Ds#188) Energy calibration improvement (i4Ds#183) Call lightcurve without generating FITS files (i4Ds#181) Respect shift_duration if file is "possibly summed on board". (i4Ds#180) Clarify flare_location coordinates (i4Ds#169) changed default behaviour of flux keyword Improvements to transmission following suggestions from @paolomassa. Value of flux = 1 passed through from stx_fsw_sd_spectrogram2ospex. Additional description of calculation of linear attenuation coefficient in stx_subc_transmission. stx_write_ospex_fits: fix grid factor recording in FITS file for srm file stx_write_ospex_fits: fix grid factor recording in FITS file stx_subc_transmission: added default to calculate low energy approximation if no input photon energies are passed fix calculation for single included grid ... # Conflicts: # stix/idl/processing/spectrogram/stx_convert_pixel_data.pro # stix/idl/processing/spectrogram/stx_convert_science_data2ospex.pro # stix/idl/processing/spectrogram/stx_convert_spectrogram.pro # stix/idl/processing/spectrogram/stx_science_data_lightcurve.pro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the possibility of some photons which occur during the dead time producing triggers after reset the nominal value of the latency results in an overcorrection at high rates. An empirical value has been determined using the high energy calibration lines which prevents them being overcorrected when the trigger rate is high but there is negligible flare influence in this range. This value should be used as the default until a more detailed model accounting for the additional “zombie photons” can be developed.