Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for finer incident energy bins in SRM #220

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mithunnps
Copy link

On exploring finer bin SRMs, it is noticed that having finer incident energy bins makes a difference to the predicted count spectrum in STIX for the same model, especially at low energies. Including new transmission files with finer binning to generate SRM files with finer incident energy bins of 10 eV in the 2-20 keV energy range and 100 eV in the 20-160 keV energy range and updates in the code to read from the new files. The transmission files are generated from stixpy by modifying the energy values in stixpy.calibration.transmission.generate_transmission_tables(). When this is merged, maybe this small change in stixpy may also be merged for consistency.

There are small differences in temperature (slight increase) and emission measure obtained with the new finer bin SRM compared to the previous versions.

with finer incident energy bins of 10 eV in 2-20 keV and 100 eV in
20-160 keV. The transmission files are generated from stixpy by
modifying the energy values in
stixpy.calibration.transmission.generate_transmission_tables()
Copy link
Collaborator

@samaloney samaloney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think need to check if this is consistent with the default DRM energy binning as I think they need to match? Not clear how it would work if the transmission and DRM are not evaluated on the same energy grid?

@FredSchuller
Copy link
Collaborator

Hi @samaloney
it's not 100% clear to me what needs to be checked and how to proceed... we have another colleague from India visiting us now, therefore it would be good if this issue could be solved relatively soon ;-)

@mithunnps
Copy link
Author

I think need to check if this is consistent with the default DRM energy binning as I think they need to match? Not clear how it would work if the transmission and DRM are not evaluated on the same energy grid?

Transmission files are reevaluated with the the finer energy bins using the stixpy routines mentioned above. New transmission files are also included in the commit. Perhaps the changes in stixpy to generate the transmission files also need to be committed, please see.

@samaloney
Copy link
Collaborator

samaloney commented Oct 14, 2024

Ok so I just had a look at the current version of the software and the drm bin edges go from 3.927 to 149.927 in steps of 0.146 (all in keV) but from the the name stix_transmission_highres_20240711_010-100eVBin.csv of the new file would suggest it goes from 10-100 with and but the contents seem to go from 2 - 159 with a step of 0.148.

I don't think either of these match the DRM but maybe I'm missing something?

Ok I see now I think what does the _10_ in the file name indicate?
Also any performance issues in terms of fitting with such large DRM?

Looks like this would work in the python code

np.hstack((np.arange(2, 20, 0.01), np.arange(20, 160, 0.1)))
array([  2.  ,   2.01,   2.02, ..., 159.7 , 159.8 , 159.9 ])

@samaloney samaloney self-requested a review October 14, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants