Extract Config #3091
Extract Config #3091
Conversation
|
Nice refactor. I'll spend some time this weekend with the PRs up and take a look. |
|
@sv99 - may you handle conflicts? |
There was a problem hiding this comment.
I need to think about this a bit. It seems we have some breaking changes on the public API front. Trying to brainstorm if this is alright knowing the upgrade path is easy or if we just adapt the existing methods to call out to init itself and new entry points exist that just take a Config.
|
PR rebased |
|
Most changes trivial. Some fields moved from Androlib to the Config because its configuration properties. I have next PR in which I move build function from Androlib to the new class ApkBuilder and decode function in the existing class ApkDecoder with some API unifications. ApkDecoder - for decoding, ApkBuilder - for building. Androlib class removed. |
|
You can see result in my fork https://github.com/sv99/Apktool |
brut.apktool/apktool-lib/src/main/java/brut/androlib/Config.java
Outdated
Show resolved
Hide resolved
brut.apktool/apktool-lib/src/main/java/brut/androlib/Config.java
Outdated
Show resolved
Hide resolved
brut.apktool/apktool-lib/src/main/java/brut/androlib/res/AndrolibResources.java
Show resolved
Hide resolved
|
Rebased and corrected most of the comments. |
|
Still looking at this. Haven't forgotten about it. |
|
thanks. merged - 10495cb |
The class Config is made on the basis of BuildOptions.