Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recently Closed Pulls: Fix cut-off #389

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Recently Closed Pulls: Fix cut-off #389

merged 3 commits into from
Sep 27, 2023

Commits on Sep 26, 2023

  1. drop bottom property form <Box> 

    This prop was causing the background/box container of the Recently
Closed Pulls cards to be cut off early from the bottom of the list.
This removes the property causing the issue and resolves the UI
cut-off.
    @jordycosta
    jordycosta committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    af299a8 View commit details
    Browse the repository at this point in the history

  2. Revert "drop bottom property form <Box>" 

    This reverts commit af299a8.
    @jordycosta
    jordycosta committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    fe6dfdb View commit details
    Browse the repository at this point in the history

  3. add height prop 

    This uses 'fit-content' to ensure that the height of the Box that contains
the Recently Closed Pulls expands all the way to the bottom of the content.

https://developer.mozilla.org/en-US/docs/Web/CSS/fit-content
    @jordycosta
    jordycosta committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    2588f2f View commit details
    Browse the repository at this point in the history