Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure standard workflow still runs with default PFA #136

Closed
wants to merge 1 commit into from
Closed

Make sure standard workflow still runs with default PFA #136

wants to merge 1 commit into from

Conversation

tmadlener
Copy link
Contributor

@tmadlener tmadlener commented Feb 9, 2024 •
edited
Loading

BEGINRELEASENOTES

  • Make sure standard workflow still runs with default PFA by ensuring the PFAtype constant is non empty.
  • Rename the default PFA configuration to PandoraPFAStd.xml

ENDRELEASENOTES

#135 introduced the PFAtype contant which leads to an exception in Marlin if the constant is empty. If iLCSoft/Marlin#55 is merged, this PR can be closed.

@tmadlener tmadlener mentioned this pull request Feb 9, 2024
Merged
@tmadlener
Copy link
Contributor Author

No longer necessary after iLCSoft/Marlin#55 has been merged.

@tmadlener tmadlener closed this Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tmadlener