Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicitly the name of the LCIO libraries #7

Closed
wants to merge 1 commit into from

Conversation

jmcarcell
Copy link
Contributor

BEGINRELEASENOTES

  • Add explicitly the names of the LCIO libraries to allow builds where the names of the libraries may not be known while configuring LCCD

ENDRELEASENOTES

It's unlikely LCIO libraries change a lot in the future and also it's maybe a better design to only link to what's needed.

@tmadlener
Copy link
Contributor

Is this still relevant? Additionally, at last SIO should have a proper target name.

@jmcarcell
Copy link
Contributor Author

Yes, this is still relevant. I don't get the SIO comment, is sio not a good name or are you referring to something else?

@tmadlener
Copy link
Contributor

SIO exports proper CMake targets (SIO::sio) that could be used, rather than hardcoding the library names

@jmcarcell
Copy link
Contributor Author

The only problem for that is that the SIO from LCIO doesn't have that but I've added it in iLCSoft/LCIO#176

@jmcarcell
Copy link
Contributor Author

Change of plans: it turns out it was linking to SIO but SIO is not needed in LCCD so it's even easier

@jmcarcell
Copy link
Contributor Author

PR updated to work with iLCSoft/LCIO#177

@tmadlener
Copy link
Contributor

superseded by #10

@tmadlener tmadlener closed this Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants