Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure to also put pre-generated headers into include directories #182

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Make sure to also put pre-generated headers into include directories #182

merged 2 commits into from
Dec 6, 2023

Conversation

tmadlener
Copy link
Contributor

BEGINRELEASENOTES

  • Also put pre-generated headers into include directories of LCIO target to make in-source builds (e.g. via. CMake's FetchContent) possible.

ENDRELEASENOTES

@arummler can you check whether this fixes the issues you described in #180?

@arummler
Copy link
Contributor

arummler commented Dec 5, 2023

There is one typo: "PROJECt" --> "PROJECT". If you fix that one it will work for me. Thanks.

tmadlener
tmadlener commented Dec 6, 2023
View reviewed changes
src/cpp/CMakeLists.txt Outdated Show resolved Hide resolved
@tmadlener
Copy link
Contributor Author

Thanks for checking. Waiting for CI to run through before merging.

@tmadlener tmadlener merged commit 2520350 into iLCSoft:master Dec 6, 2023
10 checks passed
@tmadlener tmadlener deleted the target-include-dirs branch December 6, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmadlener @arummler