Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rpath for not APPLE #35

Merged
merged 2 commits into from
May 28, 2024
Merged

Rpath for not APPLE #35

merged 2 commits into from
May 28, 2024

Conversation

andresailer
Copy link
Contributor

@andresailer andresailer commented May 16, 2024

  1. This setting of CMAKE_INSTALL_RPATH got lost in add correct rpath settings (for macos) #32
  2. I am somewhat sceptical of CMAKE_INSTALL_LIBDIR, because that comes from GnuInstallDirs (right?), bu we don't set this everywhere? But it is used in the APPLE branch?
  3. I need something like this for my nightlies put on clicdp cvmfs.

BEGINRELEASENOTES

  • RPATH: set rpath to $ORIGIN/../${CMAKE_INSTALL_LIBDIR}

ENDRELEASENOTES

@andresailer
Copy link
Contributor Author

Hi @tmadlener @gaede

Could you have a look at these changes and questions please?

Thanks!

@tmadlener
Copy link
Contributor

Answers to the ones I actually have one:

I am somewhat sceptical of CMAKE_INSTALL_LIBDIR, because that comes from GnuInstallDirs (right?),

Yes.

bu we don't set this everywhere?

If by everywhere you mean everywhere in iLCSoft? Then most likely not. It's probably a slightly mixed bag at the moment between using it and CMAKE_INSTALL_PREFIX/lib.

@andresailer
Copy link
Contributor Author

Good to merge? @tmadlener ?

@tmadlener
Copy link
Contributor

I suppose you have tested this for the LCG stacks? In that case I think we can merge

@andresailer andresailer merged commit 69e46cd into iLCSoft:master May 28, 2024
4 checks passed
@andresailer andresailer deleted the rpath branch May 28, 2024 08:05
@andresailer
Copy link
Contributor Author

If by LCG stacks you mean the ilcsoft builds on top of LCG, then yes.
But there will be a build now, and then ClicPerformance tests hopefully don't fail for not finding libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants