Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add audio output volume control #230

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kgenoe
Copy link
Contributor

@kgenoe kgenoe commented Apr 5, 2021

Adds a "Output Volume" slider Audio section in Emulator Settings.

Previously, there was no way to control the game’s volume, apart from the system level audio controls. This was mainly an issue when using the “Allow External Audio” setting. When mixing external audio and game audio, both were at full volume. Having control over the game volume makes for a better experience when mixing with external audio. It allows for having game audio quieter in the “background” while having music/podcasts/etc louder in the “foreground”.

@kgenoe
Copy link
Contributor Author

kgenoe commented Apr 5, 2021

A minor bug fix was also made to EMU_enableSound. To work properly, it's had to kick the SPU, causing audio to play for a split second. The bug was causing this kick to happen any time any other setting was changed in the Emulator Settings (if Disable Sound was active). This was an issue for the Output Volume control, as dragging the slider was causing the SPU kick to happen many times a second, causing the sound to play many times a second (again, if Disable Sound was active). To fix this, I added a check to EMU_enableSound to only perform the SPU kick if the enable state had changed.

@FrederickGeek8
Copy link
Member

Ooh! A pull request! Thanks for sending it in. I'll check it out tomorrow.

@FrederickGeek8
Copy link
Member

Sorry for the delay. It's been hectic around here. I'll set a reminder for this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants