Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximize snap layout on second screen #60

Closed
Bober95 opened this issue May 20, 2024 · 12 comments
Closed

Maximize snap layout on second screen #60

Bober95 opened this issue May 20, 2024 · 12 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@Bober95
Copy link
Contributor

Bober95 commented May 20, 2024

Describe the bug
The button and snaplayout do not work when the window is on the second screen
150358641-d646bfa5-fa66-4264-bfb4-4259029bd6bb

  • OS: Windows 11 23H2
  • .Net 8
@NotYoojun
Copy link
Member

Hello

Thanks for ur feedback. However, I'm sorry that I don't have a second display to test with.

If you got a way to fix it, please don't hesitate to open a PR or contact me.

@NotYoojun NotYoojun added bug Something isn't working help wanted Extra attention is needed labels May 21, 2024
@Bober95
Copy link
Contributor Author

Bober95 commented May 21, 2024

ok, I found the solution :)

https://stackoverflow.com/questions/49288552/how-do-i-read-the-win32-wm-move-lparam-x-y-coordinates-in-c

File: Helpers/Styles/SnapLayout
Function: IsOverButton

Change:
int positionX = lParam.ToInt32() & 0xffff; int positionY = lParam.ToInt32() >> 16;

To:
uint lparam32 = (uint)lParam.ToInt64(); short positionX = (short)(lparam32 & 0xffff); short positionY = (short)((lparam32 >> 16) & 0xffff);

@NotYoojun
Copy link
Member

Hi there, I'll dig into this when I get home. Thanks for ur ideas!

NotYoojun added a commit that referenced this issue May 22, 2024
@NotYoojun
Copy link
Member

Please try the latest commit, I applied your idea there. Could you please build the latest version and check if it still exists.

@Bober95
Copy link
Contributor Author

Bober95 commented May 22, 2024

Thanks, it works!

@Bober95 Bober95 closed this as completed May 22, 2024
@NotYoojun
Copy link
Member

Hi there, could you guys please drop us a five star for the gallery app on Microsoft Store?
Your feedback really helps us a lot! Pretty please? Thanks so much!
@Bober95 @Valkirie @ghost1372 @JeremyAnsel

https://www.microsoft.com/store/productId/9N3JS11ZC38G

@ghost1372
Copy link
Contributor

Hi @NotYoojun
Done.🌟🌟🌟🌟🌟
also if you have any time 😁🙏
https://apps.microsoft.com/search/publisher?name=Mahdi+Hosseini&hl=en-us&gl=US

@ghost1372
Copy link
Contributor

also, did you try WPF .Net 9 Preview Gallery App? it is Worse🤣

@NotYoojun
Copy link
Member

also, did you try WPF .Net 9 Preview Gallery App? it is Worse🤣

Yeah I've downloaded it and I have to say it just sucks.
No details, no animations, there's nothing at all...

@NotYoojun
Copy link
Member

NotYoojun commented May 24, 2024

Hi @NotYoojun Done.🌟🌟🌟🌟🌟 also if you have any time 😁🙏 https://apps.microsoft.com/search/publisher?name=Mahdi+Hosseini&hl=en-us&gl=US

Love it, and five stars has been dropped!
The only pity is that the package is too large.
Did you packed the whole .NET runtime?
It took me really a long time to download.

@ghost1372
Copy link
Contributor

Hi @NotYoojun Done.🌟🌟🌟🌟🌟 also if you have any time 😁🙏 https://apps.microsoft.com/search/publisher?name=Mahdi+Hosseini&hl=en-us&gl=US

Love it, and five stars has been dropped!
The only pity is that the package is too large.
Did you packed the whole .NET runtime?
It took me really a long time to download.

Yes, Self Contained for Net and WASDK, every architecture (x64, x86, arm) size is almost 80mb. I can reduce it by removing self contained but i think user may face with some issues

@NotYoojun
Copy link
Member

That just takes away a lot of trouble, ain't it?
Even though I'm again Self-contained, I have to admit that it's really convenient sometimes.
😂😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants