-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mission Control: Bug fixes related to P3 field #1722
Conversation
- Added const to make bitfield stuff more readable - changed `checkAltElevationSanity()` as it was treating P3 as a Boolean. Some times this function was called with explicitly not using absolute altitude. This is still possible. The function can accept a Boolean _or_ the P3 bitfield. - Fixed issue where alt and user action checkboxes could not be unset. - Added **.mission** filter to the load mission from file dialog box.
One other change to stop using P3 as a Boolean.
Fixed the cat's contribution.
…com/iNavFlight/inav-configurator into MrD_Fix-alt-type-in-mission-planner
Move storage of P£ til after the check
This seems to be correct now, after moving the storing of P3 around line 2125. Changing the toggle now changes the alt in the Alt (cm) box above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the slightly odd setBit
function it all seems to work as expected now so all good.
Revise setBit function
I tried your function and it worked fine. So I swapped it in as it it neater too. I'm still fairly new to all the bitwise stuff. Also, I remembered I found a bug in it which I fixed. That could have also been causing the unwanted behaviour. Either way. This is all working nicely now, so I'll get it merged, ready for RC3. |
Fixes #1721
checkAltElevationSanity()
as it was treating P3 as a Boolean. Some times this function was called with explicitly not using absolute altitude. This is still possible. The function can accept a Boolean or the P3 bitfield.