Add i18n to the LED_strip Tab #1756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good. I'll test it later and report back. |
|
Looks good. I didn't find any regressions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds all the text in LED_strip.html to i18n.
Why would I want to do this?
Since INAV configurator only supports English language for the time being, since INAV4.0, I have provided a local built Chinese version of the configurator for Chinese players, but I found that there is still a lot of text in the code that has not been added to i18n. Every time INAV releases a new version of the configurator, I have to spend a lot of time manually changing the text to Chinese before building.
This may be a relic of history, but if INAV eventually wants to support multiple languages like Betaflight, these texts will have to be added to i18n. So why not start preparing for multilingualism now?
For my first attempt, I chose the LED_strip Tab because the Betaflight configurator code gives me a good reference, since INAV and Betaflight both originate from Cleanflight.