Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magnetometer alignment tool => alignment tool #1806

Merged
merged 6 commits into from
Sep 19, 2023

Conversation

RomanLut
Copy link
Contributor

@RomanLut RomanLut commented Jul 21, 2023

I hope now alignment tool works correctly and is clear for the user.

image

  1. Removed board yaw and magnetometer alignment preset from Configuration tab
  2. Renamed Magnetometer alignment tab to Alignment tool
  3. Added board alignment roll, pitch, yaw sliders to Aligmnent tool tab
  4. Fixed multiple bugs related to roll/pitch/yaw magnetometer orientation
  5. Align_mag preset is relative to FC, but alignment_mag_roll/pitch/yaw are NOT!
  6. Clear indication which settings are used: align_mag or align_mag_xxx
  7. Align_mag_xxx are caclulated from preset + FC orientation, allowing to switch from preset to explicit angles easily

@RomanLut RomanLut changed the title magnetometer alignmnet tool => alignment tool magnetometer alignment tool => alignment tool Jul 21, 2023
@rts18
Copy link

rts18 commented Jul 22, 2023

Excellent work Roman!! This seems to cover all the bases, making the GUI more user friendly, with all the related settings now being found in this tab.
I'm away presently, so I can't test it.

If I pick up on anything its this.
5) Align_mag preset is relative to FC, but alignment_mag_roll/pitch/yaw are NOT!

It may be your wording, from a calculation perspective. But I thought it was different from a hardware perspective. I could be wrong.

Something like this : Align_mag preset is relative to the GPS/compass manufactures hardware alone.
With the Align_mag_X sliders degrees, only being used as a GUI position reference, based on the direction the user faces the compass arrow in their aircraft.
Then the tool will calculate and modify the actual align_mag_roll/pitch/yaw settings the flight software requires, relative to the FC Align_board_roll/pitch/yaw.

I think orientation preset is a pain to be truthful. It was only the laziness of the first designers who made a GPS with an integrated magnetometer. Who didn't mount the magnetometer chip with CW0(flip) being the direction of their orientation arrow, with respect to the magnetometer chip; instead of default CW270(flip).
Now all the manufactures seem to follow suit, continuing the confusion. With most using this rule. But the Orientation Preset is still required for the manufactures that actually make their hardware correctly. Or even do something different again, by having their arrow facing forward at CW 90(flip) or CW180(flip).

You may already know this, and have implemented it. But I thought I'd spell it out, just in case. Before I get a chance to test it.

@mmosca
Copy link
Collaborator

mmosca commented Jul 25, 2023

Improving the usability there was in my todo list. We get plenty of questions on this on discord :)

Another item that could help user validate the alignment is to add the heading there somewhere, users can validate that they are pointing N/E/S/W correctly.

@mmosca
Copy link
Collaborator

mmosca commented Aug 4, 2023

Functionality wise, it is great now!

Is it possible to change the layout to have the 3d model side by side with the sliders when the screen is big enough?

The way the layout works right now I end up having to scroll up and down to see the sliders and check the values on the model, and the sliders don't really need to be that wide.

@RomanLut
Copy link
Contributor Author

RomanLut commented Aug 9, 2023

Is it possible to change the layout to have the 3d model side by side with the sliders when the screen is big enough?

Changed layout, updated screenshot in the first post

@DzikuVx DzikuVx added this to the 7.0 milestone Sep 19, 2023
@DzikuVx
Copy link
Member

DzikuVx commented Sep 19, 2023

Awesome! Thanks a lot

@DzikuVx DzikuVx merged commit b738fdb into iNavFlight:master Sep 19, 2023
@tdemiralp
Copy link

Hi. Very usefull tool. is it possible to add reset button to restrat alignment tool. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants