Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add camera uptilt to HUD settings #1814

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Add camera uptilt to HUD settings #1814

merged 1 commit into from
Aug 30, 2023

Conversation

mmosca
Copy link
Collaborator

@mmosca mmosca commented Jul 29, 2023

camera uptilt was missing from the previous pull request.

image

@DzikuVx
Copy link
Member

DzikuVx commented Aug 1, 2023

I think we have to thing about lowering the number of element on OSD tab. There are just too many settings and page takes very long to load. Maybe if we spliy OSD into 2 separate ones? Like "OSD Layout" and "OSD Settings" ?
What do you think about that?

@mmosca
Copy link
Collaborator Author

mmosca commented Aug 4, 2023

I think we have to thing about lowering the number of element on OSD tab. There are just too many settings and page takes very long to load. Maybe if we spliy OSD into 2 separate ones? Like "OSD Layout" and "OSD Settings" ? What do you think about that?

Would the idea be to move the items on the right side to its own tab?

@MrD-RC
Copy link
Collaborator

MrD-RC commented Aug 4, 2023

What about if the sections were collapsable? That could look neater.

@mmosca
Copy link
Collaborator Author

mmosca commented Aug 4, 2023

Just collapsing the sections probably wouldn't make it load faster.
I am leaning on merging this one and addressing the split/load time on a subsequent pull request.

Something like this.

image

We can probably leave the video format and settings on the osd layout tab

And move alarms and the rest to the other tab, and possibly rename it to Advanced OSD settings, or something along those lines.

@MrD-RC
Copy link
Collaborator

MrD-RC commented Aug 4, 2023

I guess so long as it doesn’t change anything on the layout. It could go in a different tab. But, that would only be about 10 things. I don’t think that would increase the load time by a great deal.

@mmosca
Copy link
Collaborator Author

mmosca commented Aug 4, 2023 via email

@mmosca
Copy link
Collaborator Author

mmosca commented Aug 27, 2023

I will merge this one for now, while we investigate how to make the osd tab faster

@Jetrell
Copy link

Jetrell commented Aug 28, 2023

Its interesting to notice the OSD page load time, based on the FC processor clock speed I assume... The H743 or F765 generally load within 10s.. While the F722 and then F405 is a little slower. But the F411 takes 35s or so... It teaches me patience.

@mmosca
Copy link
Collaborator Author

mmosca commented Aug 28, 2023

One thing I would like to do is investigate the loading process of the osd tab.

We may be able to cut the cpu usage on the fc and number of calls (and time to load) if we can:

  1. Get list of visible elements
  2. Only query the state of visible elements (hopefully, in bulk, async to fool the user the loading is fast)

Current implementation seems to go through the whole list and send it in a bulk reply. It does not appear to be doing much processing though, so I am not sure if the above would be faster.

@mmosca mmosca merged commit 2a70001 into master Aug 30, 2023
@mmosca mmosca deleted the mmosca-radar-settings branch August 30, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants