Show motor wizard results in mixer preview #1910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does it still show the new number positions when you disconnect and connect again? |
Yes. It reads the existing mixer lines and shows those, unless / until you use the wizard to change them. |
DzikuVx
added a commit
that referenced
this pull request
Dec 25, 2023
Show motor wizard results in mixer preview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mixer preview has numbers showing which motor is where. Users expect that when they use the motor wizard to set the positions of the motors, the image should will reflect their changes. A common support issue is "I used the wizard to set motor 1 to right front, but it didn't change" - because the preview image still shows it as right rear.
This commit updates the preview image with the positions set by the wizard.
Demo here:
https://youtu.be/Jsm5t_u5A0Y