Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Wing Autoland #1960

Merged
merged 32 commits into from
Feb 15, 2024
Merged

Conversation

Scavanger
Copy link
Contributor

@Scavanger Scavanger commented Feb 10, 2024

Configurator support for: iNavFlight/inav#9713

Includes a overhaul of safehomes in mission control.

@stronnag
Copy link
Collaborator

Please use lower case for mission files tags and attributes, as is the INAV convention. These is also a XSD which supports this.

In order for the boolean values to validate as xs:boolean (rather than arbitrary text), the values should also be lower case.

@MrD-RC MrD-RC added this to the 7.1 milestone Feb 13, 2024
@DzikuVx DzikuVx modified the milestones: 7.1, 8.0 Feb 14, 2024
@DzikuVx
Copy link
Member

DzikuVx commented Feb 14, 2024

@Scavanger please resolve conflicts and I will want to merge asap and build releae

@DzikuVx DzikuVx merged commit 111307e into iNavFlight:release_7.1.0 Feb 15, 2024
@breadoven
Copy link
Collaborator

Settings for FW Approach Alt (m) and FW Land Alt (m) in the settings box don't save. Seems to be due to vMaxDistSH being undefined at https://github.com/iNavFlight/inav-configurator/blob/841b05ccd769aa48cda3d6c311492afc9fa3001e/tabs/mission_control.js#L3122C186-L3122C196.

Also the landing approach path doesn't display on the map seemingly because settings.fwApproachLength becomes undefined
(same for settings.fwLoiterRadius). It's initially correctly set at https://github.com/iNavFlight/inav-configurator/blob/841b05ccd769aa48cda3d6c311492afc9fa3001e/tabs/mission_control.js#L100C21-L100C46 but by the time the map is draw it's become undefined. I can't work out what's causing this.

Not sure why these are defined as Configurator settings when they are FC specific settings surely ?

Has anyone else noticed these problems or is this something specific to my Configurator build ?

@breadoven
Copy link
Collaborator

Just tried the official 7.1.0 RC1 Configurator release and the landing approach path does display correctly so no idea what's wrong with my custom build, not immediately obvious anything is overwriting the settings that become undefined.

However, the settings box/panel still won't save changed settings no doubt for the reason given above.

@breadoven breadoven mentioned this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants