Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window sizing and CLI auto complete setting fixes #1992

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

breadoven
Copy link
Collaborator

Closes #1982.

@breadoven breadoven added this to the 7.1 milestone Mar 9, 2024
@sensei-hacker
Copy link
Collaborator

Out of curiosity, what's the purpose of removing the x and y checks and drawing off the screen?

@breadoven
Copy link
Collaborator Author

breadoven commented Mar 10, 2024

Out of curiosity, what's the purpose of removing the x and y checks and drawing off the screen?

Freedom of choice surely ?

I just realised you changed this via #1847. Unfortunately I can't see how that change works if the saved screen size is bigger than the available screen size the system reports ... it just ends up stuck with the default screen size because the width/height aren't actually set (which is what happens in my case). The saved size is a few pixels bigger than the supposed available size in my case.

I changed this so it will now always align at the top left corner so it can't start off screen (except it doesn't on my screen because there are inconsistencies between the screen size/position data reported ... so you end up with a gap). Not sure if this change works for the original reason for #1847 or not @mmosca ?

@mmosca
Copy link
Collaborator

mmosca commented Mar 10, 2024

My issue was that when remote desktoping to my desktop computer that has 2 screens, sometimes the saved screen positions would be on the secondary display and I was not able to open configurator, as it was open off screen.

So I would often have to nuke the saved config to restore configurator to the first screen, or remember to make sure configurator was always on the first screen.

I can certainly test this later today, to see if it still keeps configurator from loading off screen.

@mmosca
Copy link
Collaborator

mmosca commented Mar 10, 2024

Remote desktop is fine. It actually always shows up in the primary display, which I think is ok.

@breadoven breadoven merged commit 966ee22 into iNavFlight:release_7.1.0 Mar 11, 2024
@breadoven breadoven deleted the abo_setting_fixes branch July 3, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants