Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange TIM_USE_FW_MOTOR assignment in DALRCF405 target #6303

Closed
Tygrys-1 opened this issue Nov 16, 2020 · 3 comments · Fixed by Tygrys-1/inav#2 or #6696
Closed

Strange TIM_USE_FW_MOTOR assignment in DALRCF405 target #6303

Tygrys-1 opened this issue Nov 16, 2020 · 3 comments · Fixed by Tygrys-1/inav#2 or #6696
Milestone

Comments

@Tygrys-1
Copy link
Contributor

file DALRCF405/target.c

This look strange, as the S1 and S6 are using the same timer for FW_MOTOR and FW_SERVO.
S6 should be FW_MOTOR

DEF_TIM(TIM3, CH3, PB0,  TIM_USE_MC_MOTOR | TIM_USE_MC_SERVO | TIM_USE_FW_MOTOR, 0, 0),   // S1 (1,7)  <----------
DEF_TIM(TIM8, CH1, PC6,  TIM_USE_MC_MOTOR |                    TIM_USE_FW_SERVO, 0, 0),   // S2 (2,2)
DEF_TIM(TIM1, CH3, PA10, TIM_USE_MC_MOTOR |                    TIM_USE_FW_SERVO, 0, 0),   // S3 (2,6)
DEF_TIM(TIM1, CH1, PA8,  TIM_USE_MC_MOTOR |                    TIM_USE_FW_SERVO, 0, 1),   // S4 (2,1)  (2.3 2.6)
DEF_TIM(TIM8, CH3, PC8,  TIM_USE_MC_MOTOR |                    TIM_USE_FW_SERVO, 0, 0),   // S5 (2,4)  (2.2)
DEF_TIM(TIM3, CH4, PB1,  TIM_USE_MC_MOTOR |                    TIM_USE_FW_SERVO, 0, 0),   // S6 (1,2)  <-----------
@digitalentity
Copy link
Member

Indeed, this would create a problem if anybody is using S6. Although, a workaround is to stick to conventional PWM

@digitalentity digitalentity added this to the 2.7 milestone Nov 17, 2020
@Tygrys-1
Copy link
Contributor Author

Does iNav has always two motors as a convention, or it is needed for something? This target has only one motor, so maybe it should be FW_MOTOR at S6?

@digitalentity
Copy link
Member

Two motors is not a convention. I'm not sure if any body is using this board for twin-motor or if S6 is in use at all. Most people fly either a wing (1 motor + 2 servos) or a conventional airplane (1 motor + 4 servos).

Tygrys-1 added a commit to Tygrys-1/inav that referenced this issue Mar 10, 2021
Fix timer and DMA conflicts in the target, resolves iNavFlight#6303
digitalentity added a commit that referenced this issue Mar 19, 2021
Fix the timer and DMA conflicts in the target, resolves #6303
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants