Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve climb-out logic for RTH. Different margin for airplane and copter #1568

Merged
merged 1 commit into from
Apr 23, 2017

Conversation

digitalentity
Copy link
Member

New altitude margin logic for climb-out:

Airplane: 10% of target altitude but no less than 1m
Copters: 5% of target altitude but no less than 50cm

@digitalentity digitalentity added this to the 1.7 milestone Apr 19, 2017
@oleost
Copy link
Contributor

oleost commented Apr 21, 2017

Test flown on airplane. Seemed okey, will have to verify with logs later.

Did only test regular RTH as the weather was extremely windy and no condition to do any more flying.

@oleost
Copy link
Contributor

oleost commented Apr 21, 2017

@digitalentity Not sure it works as intended?

https://drive.google.com/open?id=0B-yHzNtOXxbETG0xdl9RTEFybDA

I watched video, seems like it stops climbing the same time it turns?

The log is 3/3 where I fly.

@stronnag
Copy link
Collaborator

Flight tested. No regression on multi-rotor.

@digitalentity
Copy link
Member Author

@oleost it indeed keeps climbing during and after the turn, however last meters are tricky - we don't have proper tune - need Position Z I-gain to be able to compensate for sustained errors.

@oleost
Copy link
Contributor

oleost commented Apr 23, 2017

Okey, then it's probably okey to merge in? Or do you need some more testing?

Yes last meters are tricky, that most of the reason for this wanted feature, is it doesn't need the last meters before turning home.

@digitalentity digitalentity merged commit 3887f83 into development Apr 23, 2017
@digitalentity digitalentity deleted the de_improve_rth_climb branch April 23, 2017 10:49
@digitalentity
Copy link
Member Author

Merged. Still, issue of better tune for AltHold PIDs on airplane persists...

@oleost
Copy link
Contributor

oleost commented Apr 23, 2017

I can try 'nav_fw_pos_z_i' next time.

Got any idea where to start?

5, 20 or 100?

@digitalentity
Copy link
Member Author

@oleost unfortunately I have no idea. Try with relatively small value first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants