Enable selection between compass sensors on different buses #2522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MJ666
reviewed
Dec 4, 2017
| @@ -164,7 +164,7 @@ static bool deviceDetect(magDev_t * mag) | |||
|
|
|||
| bool ak8963Detect(magDev_t * mag) | |||
| { | |||
| mag->busDev = busDeviceInit(BUSTYPE_ANY, DEVHW_AK8963, 0, OWNER_COMPASS); | |||
| mag->busDev = busDeviceInit(BUSTYPE_I2C, DEVHW_AK8963, mag->magSensorToUse, OWNER_COMPASS); | |||
There was a problem hiding this comment.
If "BUSTYPE_I2C" instead of "BUSTYPE_ANY" is set here the AK8963 SPI compass will not be detected?
There was a problem hiding this comment.
@MJ666 oops, sorry. Will fix ASAP
|
hi i have revo and ihave external mag i doing callibrate and no poshold why |
|
and install 1.8 and do not callibrate compass all 0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New option
mag_to_usewill allow to select betwen compass sensor on internal/external I2C bus (on boards where built-in compass is on separate I2C bus - only REVO so far).Fixes #2494