Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

g-force OSD item and stats #4696

Merged
merged 13 commits into from
May 12, 2019
Merged

Conversation

shellixyz
Copy link
Collaborator

@shellixyz shellixyz commented May 9, 2019

Take over from #3566. Closes #3511. Closes #4135

Matching configurator update: iNavFlight/inav-configurator#765

@shellixyz shellixyz changed the title G-Force OSD item and stats G-Force modulus OSD item and Z G-Force stats May 9, 2019
@shellixyz shellixyz changed the title G-Force modulus OSD item and Z G-Force stats G-Force modulus OSD item and G-Force stats May 9, 2019
@shellixyz shellixyz changed the title G-Force modulus OSD item and G-Force stats G-Force OSD item and stats May 9, 2019
@shellixyz shellixyz changed the title G-Force OSD item and stats g-force OSD item and stats May 9, 2019
@Jetrell
Copy link

Jetrell commented May 10, 2019

@shellixyz Will you be including a G-force alarm set point?

@shellixyz
Copy link
Collaborator Author

@Jetrell Ok I can do that

@Jetrell
Copy link

Jetrell commented May 10, 2019

@shellixyz I noticed that you have centered this around the Z yaw axis. Do you think it would also be good to have Y pitch and X roll axis's as well. For the times we push our fixed wings a little too hard :-)

Something else that would look good....Would be the ability to select a given axis to display G-force on a graph, with the arrows.
Just some thoughts Michel.

@shellixyz
Copy link
Collaborator Author

@Jetrell Yes thought it could be useful too, I already added them, just not pushed yet

@shellixyz
Copy link
Collaborator Author

g-force graph will not be very practical with a character based OSD I'm afraid but it should be possible with a graphical OSD like the soon to be iNav OSD

@shellixyz shellixyz merged commit 706420b into iNavFlight:development May 12, 2019
@OlivierC-FR
Copy link
Contributor

OlivierC-FR commented May 18, 2019

over

Too many lines, cuts at bottom, even with PAL.

@shellixyz
Copy link
Collaborator Author

"DISARMED BY" is the last line in the stats screen so you're seeing everything

@OlivierC-FR
Copy link
Contributor

The DVR sees everything, however in the FPV goggle the last line is cut in half (standard 4:3 CCD PAL to Fatshark HD1), so I don't think the 13th/16th line is viable for display on some setups.

@shellixyz
Copy link
Collaborator Author

Maybe we can make what's displayed on the stats screen configurable or even better we could change the stats screen to use icons instead of text labels to be able to display more stuff

@Jetrell
Copy link

Jetrell commented May 30, 2019

Maybe we can make what's displayed on the stats screen configurable

@shellixyz Have you put anymore thought into this? I think it would be useful to have it configurable.

@shellixyz
Copy link
Collaborator Author

I think the stats page is too limited for now. A lot of space is lost. It could just be reformatted to be able to display more info either by using icons instead of labels. We could alternatively merge lines together for example max speed and distance, and current and power. Another alternative is to make labels shorter and make two columns

@Jetrell
Copy link

Jetrell commented May 30, 2019

@shellixyz I see your meaning. When you first mentioned it, I was think along the lines of the Betaflight configurator. Which has the ability for the user to select what information they want displayed on the stats.
But that's fine.

I have another request for the G force readout.
I used it today, And easily forgot what axis was what, when looking at a glance.
Would you be willing to add descriptive symbols to the OSD. So we can tell at a Glance which axis a particular G force is reading out?

@shellixyz
Copy link
Collaborator Author

@Jetrell

When you first mentioned it, I was think along the lines of the Betaflight configurator

It was the initial idea. Not sure what's best. I think we'll start with reformatting.

Would you be willing to add descriptive symbols, something like these, to the OSD

Sure, adding symbols is a good idea. They were not added because I'm not a graphics designer. I'm going to ask the authors or Vision and Clarity to make new symbols

@Jetrell
Copy link

Jetrell commented Jun 3, 2019

@shellixyz If you don't get around to reformatting the stats display.
Is there the possibility of just putting back - Traveled Distance - Max Distance - Average Efficiency and Max speed.
Even if Max Power is removed. And the Max G-force. Because Max G-force is also shown on the Min / Max G-force stats, right below it.
I really miss seeing the above mentioned stats. Especially after a long flight with a fixed wing. Or on the DVR playback.

Thanks

@shellixyz
Copy link
Collaborator Author

@Jetrell I'm going to do something about that soon. Max g-force and max Z axis g-force are not the same thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants