Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed default settings for fixed wing throttle smoothing in navigation modes #6361

Merged

Conversation

Airwide
Copy link
Contributor

@Airwide Airwide commented Dec 3, 2020

This pull request contains a proposal of changed default settings for the new throttle smoothing feature introduced in pull request #6104. The change is a result of the testing performed by me and @avsaase, and will let all fixed wing pilots take advantage of this feature by default in the next release.

The proposed defaults:
nav_fw_pitch2thr_smoothing = 6 which equals a low pass filter cutoff frequency of 0.14 Hz.
nav_fw_pitch2thr_threshold = 50 which equals +/- 5 degrees deadband around the filtered pitch angle.

@avsaase
Copy link
Member

avsaase commented Dec 3, 2020

I have not tested this yet with nav_fw_pitch2thr_smoothing = 6 so maybe it works well, but intuitively a cutoff frequency of 0.14Hz seems very low to me. I don't have much experience with low-pass filters so I could be wrong. Maybe this is asking too much, but could you maybe apply this filter to a simulated time series so it becomes clear how this filter behaves in this application?

@Airwide
Copy link
Contributor Author

Airwide commented Dec 3, 2020

I have not tested this yet with nav_fw_pitch2thr_smoothing = 6 so maybe it works well, but intuitively a cutoff frequency of 0.14Hz seems very low to me. I don't have much experience with low-pass filters so I could be wrong. Maybe this is asking too much, but could you maybe apply this filter to a simulated time series so it becomes clear how this filter behaves in this application?

@avsaase I tested it with a cutoff frequency of 0.1 Hz in this post. As you can see in the first screenshot, the 10 degree pitch change was outside of the 5 degree deadband for only 1 second before the filtered average caught up the 5 degree difference.

The cutoff frequency for a low pass filter is defined as the frequency where changes of the input signal is transfered to the output signal by 50% (-3 dB).

I figured 0.14 Hz is a bit more conservative than the tested 0.1 Hz which didn't feel slow at all.

WDYT?

@digitalentity digitalentity added this to the 2.7 milestone Dec 5, 2020
@digitalentity digitalentity merged commit b5c332d into iNavFlight:master Dec 5, 2020
@digitalentity digitalentity added the Release Notes Add this when a PR needs to be mentioned in the release notes label Dec 5, 2020
@avsaase
Copy link
Member

avsaase commented Dec 5, 2020

I could be wrong, but shouldn't the defaults be changed here as well?

.pitch_to_throttle_smooth = 0,
.pitch_to_throttle_thresh = 0,

@Airwide
Copy link
Contributor Author

Airwide commented Dec 6, 2020

I could be wrong, but shouldn't the defaults be changed here as well?

.pitch_to_throttle_smooth = 0,
.pitch_to_throttle_thresh = 0,

Good catch! I’ll fix it when I get home tonight. Thanks!

@Airwide Airwide deleted the aw-set-nav-smooth-throttle-defaults branch December 7, 2020 07:11
@MrD-RC MrD-RC mentioned this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Notes Add this when a PR needs to be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants