Adjust CMS and statistics page layout for HD OSD #7871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure the statistics screens are fully visible when in HD 4:3 cut.
|
@geoffsim is this ready to merge? |
|
Yes it is.
…Sent from my phone
On 13 Mar 2022, at 09:09, Paweł Spychalski ***@***.***> wrote:
@geoffsim is this ready to merge?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.
|
DzikuVx
requested changes
Mar 13, 2022
src/main/io/osd.c
Outdated
| @@ -32,7 +32,7 @@ | |||
| #include "platform.h" | |||
|
|
|||
| FILE_COMPILE_FOR_SPEED | |||
|
|
|||
| #define USE_OSD | |||
There was a problem hiding this comment.
Apologies for that - a temporary change that should not have been released.
I have removed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CMS and statistics screens are cropped on the LHS when in HD 4:3 cut mode, making them unusable.
These changes adjust the columns of the elements to ensure the screens are fully visible when in HD mode.
(changes tested on both Analog and Digital HD systems)