Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop PCA9685 support #8032

Merged
merged 2 commits into from
May 14, 2022
Merged

Drop PCA9685 support #8032

merged 2 commits into from
May 14, 2022

Conversation

DzikuVx
Copy link
Member

@DzikuVx DzikuVx commented May 12, 2022

No description provided.

@DzikuVx DzikuVx added this to the 5.0 milestone May 12, 2022
@DzikuVx DzikuVx added the Release Notes Add this when a PR needs to be mentioned in the release notes label May 12, 2022
@DzikuVx DzikuVx merged commit 4fbc0f2 into master May 14, 2022
@DzikuVx DzikuVx deleted the dzikuvx-drop-pca9685 branch May 14, 2022 09:01
@stronnag
Copy link
Collaborator

stronnag commented May 14, 2022

Sigh. Damn it, dman it breaks blackbox_decode for all previous firmware version by moving up the enums rc/runtime_config.h rather than just obsoleting the removed item.

Mea culpa, it doesn't.

@Windoofs
Copy link

Is there a technical reason why the support was removed? I am shure @DzikuVx has a bulletproof argument for this decision. Maybe the anonymous telemetry collected via Configurator showed the lack of usage in the real word ?

For my usage I was able to revert the commits in 5.0.0-RC3 and build the needed targets. Testing on hardware will be done on the weekend. The PCA9685 was a welcomed "hack" to utilize cheaper/older MCUs for bigger/smarter drones. This is handy feature during a global chip crisis.

This was the only issue while updating my fleet to 5.0.0-RC3.

@DzikuVx
Copy link
Member Author

DzikuVx commented Jun 21, 2022

@Windoofs yes, almost nobody was using it. A few cases in total. The suggested way of handling it, it to output servos as SBUS stream and use SBUS-to-PWM decoder when needed. That's faster and more reliable than I2C connected PCA9685

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Notes Add this when a PR needs to be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants