Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RTH Climb First enum ambiguity #8069

Merged
merged 1 commit into from
May 30, 2022
Merged

Fix RTH Climb First enum ambiguity #8069

merged 1 commit into from
May 30, 2022

Conversation

breadoven
Copy link
Collaborator

Cleans up RTH Climb First enum setting definition removing ON/OFF ambiguity.

@MrD-RC
Copy link
Collaborator

MrD-RC commented May 30, 2022

Nice. Maybe we can get this in 5.0.0RC2.

@DzikuVx DzikuVx added this to the 5.0 milestone May 30, 2022
@DzikuVx DzikuVx changed the base branch from master to release_5.0.0 May 30, 2022 10:04
@DzikuVx
Copy link
Member

DzikuVx commented May 30, 2022

Lets put it in the next RC then. @MrD-RC do we need configurator changes?

@MrD-RC
Copy link
Collaborator

MrD-RC commented May 30, 2022

I don't think so off the top of my head but can check. I believe the select box is using data directly from MSP on that parameter.

@breadoven
Copy link
Collaborator Author

Shouldn't affect anything, more of an admin change than anything else.

@DzikuVx
Copy link
Member

DzikuVx commented May 30, 2022

Then let's merge it. Thanks @breadoven

@DzikuVx DzikuVx merged commit 3914c4f into iNavFlight:release_5.0.0 May 30, 2022
@breadoven breadoven deleted the abo_spiral_climb_enum_fix branch June 4, 2022 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@breadoven @MrD-RC @DzikuVx