remove obsolete static_assert #9077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DzikuVx
approved these changes
May 25, 2023
sensei-hacker
pushed a commit
to sensei-hacker/inav_unofficial_targets
that referenced
this pull request
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a myriad of OSD changes since the static_assert was introduced, the assert is now obsolete and it's only current purpose is to prevent users easily compiling firmware with
USE_MSP_RC_OVERRIDEdefined.Currently the difference between
ARRAYLEN(menuOsdElemsEntries)andOSD_ITEM_COUNTis c. 40 and even if it could be revived, remains a maintenance burden.