Add new Blinds Accessory for controlling roller motor shades #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add additional Fan/Fan Light settings to config schema iRayanKhan#458
* Make MultiState requests optional on Fan accessory * refactor
Notifies on ring with a snapshot. Notifies when a user presses the lock or gate buttons on another device. Does not provide video or audio. Does not allow the user to control the lock or gate. Co-authored-by: Andrew Kurowski <[email protected]>
|
Hi @ThisIsQasim, Thanks for the PR. Would it be possible to add this into the existing simple blinds accessory file as another type? |
|
Hi @05TEVE, I can probably get it to work with a single file but I think we would end up with a lot of spaghetti code because the existing “Simple Blind Accessory” isn’t simple at all. It was for older blinds that didn’t report current position so it would calculate the position based on the time it took to fully open and close the blind. You can imagine the code for it wasn’t straight forward. Anyways, have a look and if you still think it would be best to consolidate I’ll give it a shot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the project is getting some attention again, I am re-creating #324 which is a rebase of #282