Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing habit goals should trigger a sort refresh #1131

Closed
2 tasks done
hiqua opened this issue Sep 28, 2021 · 2 comments · Fixed by #1350
Closed
2 tasks done

Changing habit goals should trigger a sort refresh #1131

hiqua opened this issue Sep 28, 2021 · 2 comments · Fixed by #1350
Labels
bug Something is not behaving as the developers expected confirmed The developers have been able to confirm that the issue is valid
Milestone
Loop 2.1

Comments

@hiqua
Copy link
Collaborator

hiqua commented Sep 28, 2021

Pre-submission checklist

  • I am submitting a bug report, not a feature request.
  • I have searched for similar issues, but did not find any matches.

Description

If we sort by status, the order depends on the goals, but changing habit goals does not trigger a sort refresh, meaning that the sort can become outdated after such a change.

Steps to reproduce

  1. sort by status (maybe by score as well? Not sure if that's impacted by a change of goals)
  2. change a habit goal so that a habit that was not ticked becomes automatically ticked (e.g. because done yesterday and the habit is now once a week)
  3. see that this habit hasn't changed its position

System information

  • App version: 2.0.3
@hiqua hiqua added bug Something is not behaving as the developers expected confirmed The developers have been able to confirm that the issue is valid labels Sep 28, 2021
@hiqua
Copy link
Collaborator Author

hiqua commented Sep 28, 2021

I haven't checked that the latest version has this bug yet, I'll try to do that when I get the chance, if nobody else has in the meantime.

@hiqua
Copy link
Collaborator Author

hiqua commented Oct 21, 2021

A day change should also trigger the sort.

@iSoron iSoron added this to the Loop 2.1 milestone Nov 23, 2021
hiqua added a commit to hiqua/uhabits that referenced this issue Apr 14, 2022
@hiqua
Resort habit list after habit edit
49996dc 
Fixes iSoron#1131.
hiqua added a commit to hiqua/uhabits that referenced this issue Apr 14, 2022
@hiqua
Resort habit list after habit edit
3ae6da0 
Fixes iSoron#1131.
@hiqua hiqua mentioned this issue Apr 14, 2022
Merged
hiqua added a commit to hiqua/uhabits that referenced this issue Apr 16, 2022
@hiqua
Add regression test for iSoron#1131
44bbc30
hiqua added a commit to hiqua/uhabits that referenced this issue Apr 16, 2022
@hiqua
Add regression test for iSoron#1131
e219631
hiqua added a commit to hiqua/uhabits that referenced this issue Apr 16, 2022
@hiqua
Resort habit list after habit edit
76e8dd5 
Fixes iSoron#1131.
iSoron pushed a commit that referenced this issue Apr 21, 2022
@hiqua
Resort habit list after habit edit (#1350)
c453810 
* Add regression test for #1131
* Resort habit list after habit edit

Fixes #1131.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something is not behaving as the developers expected confirmed The developers have been able to confirm that the issue is valid
Projects
None yet
Milestone
Loop 2.1
Development

Successfully merging a pull request may close this issue.

Resort habit list after habit edit hiqua/uhabits
2 participants
@hiqua @iSoron