Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error output not being included in rush test/cover summaries. #2281

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

wgoehrig
Copy link
Member

This has been broken ever since we updated to use mocha 8 in #1190. Turns out we just needed to react a change (mochajs/mocha#3725) in the base reporter intended to prevent tests from accidentally redirecting reporter output.

Also updated betools to stop logging useless "Error: Command failed: ..." errors (and call stacks) when a test process fails.

Also stop logging useless "Error: Command failed: ..." errors/call stacks when a test process fails.
Copy link
Contributor

@kabentley kabentley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My hero!

{{ electronic hug emoji }}

@wgoehrig wgoehrig merged commit 4d1e022 into master Sep 17, 2021
@wgoehrig wgoehrig deleted the fix-rush-test branch September 17, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants