Can't create multiple volumes from the same volume

[rmb938]

When creating a volume where the source is a volume. The first creation works, but if I create another volume, it fails.

2023-01-28 22:38:25.687 407797 INFO cinder.volume.drivers.ixsystems.freenasapi [None req-a123df1f-3880-47a7-ae6c-53b9eddba151 fff44df7b41d4fd39edf513ca497a8c4 ba20d749b68045bba695de9dd0123471 - - - -] Error returned from server: "Failed to snapshot tank/vms/volume-abc2c893@snap-cabc2c893: dataset already exists"

The driver tries to create a duplicate snapshot with the same name as the first one.

I believe this is the code that is causing the issue https://github.com/iXsystems/cinder/blob/master/driver/ixsystems/iscsi.py#L286-L287

The name key in temp_snapshot probably should be the volume.id, not referencing the source volume.

[YiHuangDB]

Hi Ryan, thank you for reporting this issue. I can reproduce the issue on my side. I will let you know once it is fixed. There are actually multiple issues with current snapshot driver implementation, including the code location you point out. We will address that and let you know.

[YiHuangDB]

Hi Ryan, this issue has been fixed with PR #33 and merged to master branch, if you have any issue with the fix, technically exactly the same like you mentioned in your post, appreciate your comments and feedbacks.