Skip to content

Commit

Permalink
Update config and swiftlint warnings
Browse files Browse the repository at this point in the history
Update runner target

Update
  • Loading branch information
moglistree committed Nov 14, 2023
1 parent 19f647d commit 4d047b5
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 16 deletions.
18 changes: 9 additions & 9 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@
version: 2.1

anchors:
- &test_device "iPhone 14"
- &test_device_os "16.2"
- &test_device "iPhone 15"
- &test_device_os "17.0"
- &clean_before_build true
- &default_executor
macos:
xcode: "14.2.0"
xcode: "15.0.0"

env:
global:
Expand Down Expand Up @@ -145,15 +145,15 @@ jobs:
- store_test_results:
path: swiftlint.html

test-xcode13-ios15:
test-xcode14-ios16:
macos:
xcode: "13.0.0"
xcode: "14.0.0"
steps:
- test_main_project:
simulator: "iPhone 13"
os_version: "15.0"
simulator: "iPhone 14"
os_version: "16.0"

test-xcode14-ios16:
test-xcode15-ios17:
<<: *default_executor
steps:
- test_main_project
Expand All @@ -170,7 +170,7 @@ workflows:
jobs:
- swiftlint:
version: 0.49.1
- test-xcode13-ios15
- test-xcode14-ios16
- test-xcode15-ios17
- test-example-login

12 changes: 6 additions & 6 deletions Flow/Bridges/Signal+Combine.swift
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ extension CoreSignal {
final class SignalPublisher: Publisher, Cancellable {
typealias Output = Value
typealias Failure = Error

internal var signal: CoreSignal<Kind, Value>
internal var bag: CancelBag

Expand All @@ -22,7 +22,7 @@ extension CoreSignal {

func receive<S>(
subscriber: S
) where S : Subscriber, Failure == S.Failure, Value == S.Input {
) where S: Subscriber, Failure == S.Failure, Value == S.Input {
// Creating our custom subscription instance:
let subscription = EventSubscription<S>()
subscription.target = subscriber
Expand Down Expand Up @@ -56,11 +56,11 @@ extension CoreSignal {
cancel()
}
}

@available(iOS 13.0, macOS 10.15, *)
final class EventSubscription<Target: Subscriber>: Subscription
where Target.Input == Value {

var target: Target?

func request(_ demand: Subscribers.Demand) {}
Expand All @@ -76,12 +76,12 @@ extension CoreSignal {
_ = target?.receive(completion: .finished)
}
}

func trigger(for value: Value) {
_ = target?.receive(value)
}
}

@available(iOS 13.0, macOS 10.15, *)
public var asAnyPublisher: AnyPublisher<Value, Error> {
SignalPublisher(signal: self).eraseToAnyPublisher()
Expand Down
2 changes: 1 addition & 1 deletion Flow/Bridges/Signal+SwiftUI.swift
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,6 @@ extension CoreSignal where Kind == Read {
set: { _ in }
)
}

}
#endif

0 comments on commit 4d047b5

Please sign in to comment.