Added support for multiline headers. #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bit of a tradeoff here. I decided to just send additional lines with no separator from previous lines. One could send newlines with all header values, the way part data works, but that could possibly be a breaking change. One could also add additional states, rewind the index and add newlines only on multiline headers, but that seemed like too much complexity.
|
Hi! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bit of a tradeoff here. I decided to just send additional lines with no
separator from previous lines. One could send newlines with all header
values, the way part data works, but that could possibly be a breaking
change. One could also add additional states, rewind the index and add
newlines only on multiline headers, but that seemed like too much
complexity.
This patch is meant to resolve #14.