-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
export partial and strict #140
Conversation
@jakebailey I hope it is not rude to ask for your help. The esmock's interface is not easily described in typescript and I'm not sure how to achieve passing results here. I don't want the types file to be big but maybe its inevitable. Would you give me your advice? |
where the typescript errors occur, this issue seems related microsoft/TypeScript#22063 if typescript supported simplified function declarations this file would be easier to write |
I'm leaning toward exporting partial as the default, with high-chance the next PR would change that. I need to mention it because it would be obnoxious if I take help from you, then, right after, change the interface in some way you disagree with. |
Don't worry about it, it's your library. Truthfully I can't use it anymore because of bugs with loaders and coverage gathering. :( |
probably "esmock.partial.p" and "esmock.strict.p" will be dropped from the tests. typescript doesn't handle the inteface |
@tripodsan please review I'm interested to make a follow-up PR that sets partial as the default export for the 2.0 release |
typescript tests are passing here and so changes here do work with typescript, though I haven't used them in typescript-aware editor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
support these