Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add x.com provider #714

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Add x.com provider #714

merged 1 commit into from
Dec 8, 2023

Conversation

adrien-chinour
Copy link
Contributor

@adrien-chinour adrien-chinour commented Oct 27, 2023

Adding x.com as provider due to twitter rebranding.

It's the same oEmbed api but with domain x.com.

Using same provider but with x.com content not working (404) :

curl --request GET -iL --url 'https://publish.twitter.com/oembed?url=https://x.com/Interior/status/507185938620219395'

Using oEmbed api on platform.x.com working (302->200) :

curl --request GET -iL --url 'https://publish.x.com/oembed?url=https://x.com/Interior/status/507185938620219395'

#710

@iamcal iamcal merged commit 006cd8f into iamcal:master Dec 8, 2023
1 check passed
@iamcal
Copy link
Owner

iamcal commented Dec 8, 2023

Your PR has been merged and site has been updated, thanks.

Using the central registry via HTTP is highly discouraged - you should instead use the discovery mechanism to allows services to consume OEmbed resources: https://oembed.com/#section4

If you need to consume the registry data, please use the NPM package as detailed in the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants