Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release to both github and pypi via workflow #188

Merged
merged 6 commits into from
Oct 27, 2022

Conversation

ahmubashshir
Copy link
Contributor

Changes:

  • workflow: Add release workflow
  • poetry.lock: Corrupt urlmatch OS X tarball checksum to avoid it

Requirements:

Pypi.org auth token added as a secret named PYPI_TOKEN

@iamkroot
Copy link
Owner

Blocked by pypi/support#1735

@iamkroot
Copy link
Owner

With poetry 1.2, we don't need to corrupt the urlmatch checksum anymore

@iamkroot iamkroot linked an issue Oct 22, 2022 that may be closed by this pull request
@iamkroot
Copy link
Owner

iamkroot commented Oct 22, 2022

Hey @ahmubashshir I have updated the workflow a bit. But github isn't allowing me to push to that from the CLI for some reason (permission denied). Could you please try adding me as a collaborator to your fork so I can commit there?

@iamkroot
Copy link
Owner

@ahmubashshir Seems like there are conflicts. Can be fixed with git rebase master --strategy-option=theirs.

I can't do a force-push on your branch, so you'll need to run that. Then we should be able to merge this

@ahmubashshir
Copy link
Contributor Author

ahmubashshir commented Oct 23, 2022 via email

ahmubashshir and others added 6 commits October 24, 2022 18:45
* Update action versions
* Use cache directly from setup-python action
* Specify python-version matrix for test job
* Remove pytest install step
@ahmubashshir
Copy link
Contributor Author

does it work now?

@iamkroot
Copy link
Owner

Looks good!

@iamkroot iamkroot merged commit 5bc6d52 into iamkroot:master Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFE] Release with github-actions
2 participants