fix: duration plugin getter get result 0 instead of undefined (#2369)

iamkun · Jul 15, 2023 · 061aa7e · 061aa7e
1 parent f0a0b54
commit 061aa7e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/plugin/duration/index.js b/src/plugin/duration/index.js
@@ -198,7 +198,7 @@ class Duration {
     } else {
       base = this.$d[pUnit]
     }
-    return base === 0 ? 0 : base // a === 0 will be true on both 0 and -0
+    return base || 0 // a === 0 will be true on both 0 and -0
   }
 
   add(input, unit, isSubtract) {

diff --git a/test/plugin/duration.test.js b/test/plugin/duration.test.js
@@ -186,6 +186,12 @@ describe('Add', () => {
   expect(a.add({ days: 5 }).days()).toBe(6)
 })
 
+describe('Add to a dayjs()', () => {
+  const a = dayjs()
+  const b = dayjs.duration({ hours: 7, minutes: 10 })
+  expect(a.add(b)).toEqual(a.add(7, 'hours').add(10, 'minutes'))
+})
+
 test('Add duration', () => {
   const a = dayjs('2020-10-01')
   const days = dayjs.duration(2, 'days')