Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advanced format bug in zh-cn #242

Closed
geekdada opened this issue Jun 13, 2018 · 2 comments
Closed

Advanced format bug in zh-cn #242

geekdada opened this issue Jun 13, 2018 · 2 comments
Labels
☢️Bug Something isn't working

Comments

@geekdada
Copy link

Sample: https://runkit.com/geekdada/5b20ef49d06d8b0013fefe12
Expected value: xx日
@iamkun
Copy link
Owner

iamkun commented Jun 13, 2018 •
edited
Loading

@geekdada
Thanks, will fix in next release

locale ordinal should be

ordinal: n => `${n}日`,

@iamkun iamkun added the ☢️Bug Something isn't working label Jun 13, 2018
iamkun added a commit that referenced this issue Jun 14, 2018
@iamkun
fix: fix Advanced format bug in zh-cn
0c07874 
close #242
@iamkun iamkun mentioned this issue Jun 14, 2018
Merged
iamkun pushed a commit that referenced this issue Jun 14, 2018
@semantic-release-bot
chore(release): 1.6.8 [skip ci]
c2a487c 
## [1.6.8](v1.6.7...v1.6.8) (2018-06-14)

### Bug Fixes

* fix  Advanced format bug in zh-cn ([0c07874](0c07874)), closes [#242](#242)
@iamkun
Copy link
Owner

iamkun commented Jun 14, 2018 •
edited
Loading

@geekdada
🎉 This issue has been resolved in version 1.6.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this issue May 10, 2022
@andrewhood125ruhuc
chore(release): 1.6.8 [skip ci]
720ddad 
## [1.6.8](iamkun/dayjs@v1.6.7...v1.6.8) (2018-06-14)

### Bug Fixes

* fix  Advanced format bug in zh-cn ([0c07874](iamkun/dayjs@0c07874)), closes [#242](iamkun/dayjs#242)
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this issue May 10, 2022
@andrewhood125ruhuc
chore(release): 1.6.8 [skip ci]
162a6d4 
## [1.6.8](iamkun/dayjs@v1.6.7...v1.6.8) (2018-06-14)

### Bug Fixes

* fix  Advanced format bug in zh-cn ([0c07874](iamkun/dayjs@0c07874)), closes [#242](iamkun/dayjs#242)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
☢️Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@geekdada @iamkun