Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation for Indonesian languange #193

Merged
merged 5 commits into from
May 25, 2018
Merged

Add translation for Indonesian languange #193

merged 5 commits into from
May 25, 2018

Conversation

muhibbudins
Copy link
Contributor

@muhibbudins muhibbudins commented May 24, 2018

Hi @iamkun,

I try to add translation for Indonesian Language with key name id, and then i add some condition at .gitignore file like this :

# build
locale/
!src/locale/
plugin/
dayjs.min.js

To ignore only locale/ folder not src/locale/.

Thank you

@codecov-io
Copy link

codecov-io commented May 24, 2018

Codecov Report

Merging #193 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #193   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     16    +1     
  Lines         308    311    +3     
  Branches       52     52           
=====================================
+ Hits          308    311    +3
Impacted Files Coverage Δ
src/locale/id.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfd8f40...4d6f37c. Read the comment docs.

@iamkun
Copy link
Owner

iamkun commented May 24, 2018

Thanks @muhibbudins .

However, I think, locale/ should ignore only root/locale/ not other deep locale folder? And maybe I'm wrong.

@muhibbudins
Copy link
Contributor Author

Urwell @iamkun ,

Yups, but i don't know why on my VSCode and Terminal they ignore every locale/ folder haha

src/locale/id.js Outdated
Q: 'kuartal',
Y: 'tahun',
DATE: 'tanggal',
weekdays: 'Minggu_Senin_Selasa_Rabu_Kamis_Jum\'at_Sabtu'.split('_'),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be Jumat ? I don't know, just feel weird

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm okey i'll fix it

@iamkun
Copy link
Owner

iamkun commented May 24, 2018

Besides, I'm going to merge pr#189, and there's a little change in our locale file.
Would you please update your translation a bit to fit our new code?

You could check the diff in src/locale/es.js locale here:
https://github.com/iamkun/dayjs/pull/189/files

PS, this might could not pass our current test, but don't worry, after merge it will be fine

@muhibbudins
Copy link
Contributor Author

Hi @iamkun ,

I'm already update based src/locale/es.js on #189.

Thank you

@iamkun
Copy link
Owner

iamkun commented May 24, 2018

Great THX

@muhibbudins
Copy link
Contributor Author

Urwell @iamkun
Thanks for awesome project 😃

@iamkun iamkun merged commit d7ed7cb into iamkun:master May 25, 2018
@iamkun
Copy link
Owner

iamkun commented May 25, 2018

🎉 This PR is included in version 1.6.4 🎉@muhibbudins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants