Add Finnish locale #351
Merged
Add Finnish locale #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds basic support for Finnish locale but atm. proper Finnish support can't be implemented until issue iamkun#302 is fixed. relativeTime properties are now configured for past tense usage only because I think it's a more common use case with this kind of library. For now using future tense with this locale will result in incorrect forms and text that doesn't make sense.
Codecov Report
@@ Coverage Diff @@
## master #351 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 38 39 +1
Lines 410 413 +3
Branches 55 55
=====================================
+ Hits 410 413 +3
Continue to review full report at Codecov.
|
Week names and month names are not capitalized in Finnish so having them all lowercase in the locale file is intentional. They should only start with a capital in case the word is a first word in a sentence or title.
|
@Haprog THX |
|
🎉 This PR is included in version 1.7.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds basic support for Finnish locale but atm. proper Finnish support can't be implemented until issue #302 is fixed.
relativeTimeproperties are now configured for past tense usage only because I think it's a more common use case with this kind of library.For now using future tense with this locale will result in incorrect forms and text that doesn't make sense.