Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update japanese doc #440

Merged
merged 3 commits into from
Jan 4, 2019
Merged

update japanese doc #440

merged 3 commits into from
Jan 4, 2019

Conversation

butaosuinu
Copy link
Contributor

  • translate updated docs
  • change the link to Buddhist Era wikipedia to japanese wikipedia

#171

@iamkun
Copy link
Owner

iamkun commented Jan 4, 2019

THX

@codecov-io
Copy link

codecov-io commented Jan 4, 2019 •
edited
Loading

Codecov Report

Merging #440 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #440   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          49     49           
  Lines         384    384           
  Branches       59     59           
=====================================
  Hits          384    384

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 187291e...1b81dea. Read the comment docs.

iamkun
iamkun reviewed Jan 4, 2019
View reviewed changes
docs/ja/API-reference.md
@@ -482,49 +480,52 @@ dayjs().isAfter(dayjs()); // false
dayjs().isAfter(dayjs(), 'year'); // false
```

### Is a Dayjs `.isDayjs(compared: any)`
#### Is a Dayjs
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the table of contents accordingly, to ensure the anchor works.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, fixed.

@iamkun iamkun merged commit 6388130 into iamkun:master Jan 4, 2019
@iamkun
Copy link
Owner

iamkun commented Jan 14, 2019

🎉 This PR is included in version 1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamkun iamkun iamkun left review comments

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@butaosuinu @iamkun @codecov-io