Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fil locale (same as tl-ph) #594

Closed
wants to merge 1 commit into from

Conversation

aadityataparia
Copy link
Contributor

Filipino language (fil) is synonym to tagalog language (tl-ph)

https://en.wikipedia.org/wiki/Filipino_language#Filipino_vs._Tagalog

@codecov-io
Copy link

codecov-io commented May 13, 2019

Codecov Report

Merging #594 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #594   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files       154    155    +1     
  Lines       982    984    +2     
  Branches    140    140           
===================================
+ Hits        982    984    +2
Impacted Files Coverage Δ
src/locale/fil.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 977d305...0e1f5c6. Read the comment docs.

@iamkun
Copy link
Owner

iamkun commented May 13, 2019

Thanks.

One more question, what's the difference between Philippine languages (phi), fil and tl-ph, and what's tl-ph stand for (is it two combined language)

@aadityataparia
Copy link
Contributor Author

aadityataparia commented May 13, 2019

They are basically same, and tl-ph is Tagalog (Philippines), tl alias can also be added if we want that too. They are just different ISOs, tl -> two letter language code, tl-ph langauge + country (is usually used when same language is used in different countries), fil -> three letter language code.

I wanted to add fil because I am using it in i18n.

Screen Shot 2019-05-13 at 12 17 19

@iamkun
Copy link
Owner

iamkun commented May 13, 2019

As mentioned in #171, we use https://en.wikipedia.org/wiki/List_of_ISO_639-2_codes as a reference.
We use tl-ph to keep the same with moment.js, surprisingly, it's not listed on that table (but fil does)

@aadityataparia
Copy link
Contributor Author

aadityataparia commented May 13, 2019

As mentioned in #171, we use https://en.wikipedia.org/wiki/List_of_ISO_639-2_codes as a reference.
We use tl-ph to keep the same with moment.js, surprisingly, it's not listed on that table (but fil does)

Rename tl-ph to tl maybe. Or create alias to keep it compatible with moment.

Also this ISO doesn't have language-country codes. So, not very surprising 😉

@iamkun
Copy link
Owner

iamkun commented May 13, 2019

Found two related issue / pr in moment.js

moment/moment#3054

moment/moment#4239

@aadityataparia
Copy link
Contributor Author

Tried this today, even this works

dayjs.locale('fil', dayjs.Ls['tl-ph'])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants