Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:add/set/subtract support Object parameter #886

Closed
wants to merge 5 commits into from
Closed

feat:add/set/subtract support Object parameter #886

wants to merge 5 commits into from

Conversation

zerooverture
Copy link
Contributor

add/set/subtract support Object parameter
and constructor support Array/Object parameter

zerooverture and others added 4 commits April 26, 2020 14:44
if  require('dayjs/locale/en')
instance.$locale().relativeTime is undefined
fix: Update RelativeTime plugin default config (#883)
add/set/subtract support Object parameter
and constructor support Array/Object parameter
@codecov
Copy link

codecov bot commented Apr 27, 2020

Codecov Report

Merging #886 into dev will decrease coverage by 1.31%.
The diff coverage is 37.93%.

Impacted file tree graph

@@             Coverage Diff             @@
##               dev     #886      +/-   ##
===========================================
- Coverage   100.00%   98.68%   -1.32%     
===========================================
  Files          164      164              
  Lines         1341     1367      +26     
  Branches       281      286       +5     
===========================================
+ Hits          1341     1349       +8     
- Misses           0       18      +18     
Impacted Files Coverage Δ
src/index.js 90.90% <37.93%> (-9.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db642ac...882611c. Read the comment docs.

@iamkun
Copy link
Owner

iamkun commented Apr 27, 2020

Thanks.

  1. It will be better to support these features as separate plugins.

  2. Please add the related unit test.

@zerooverture
Copy link
Contributor Author

commit a standalone plugin[#887]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants