Use struct for unpack (and add support for floats) #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No sense defining our own "s2n" routines when struct does everything required (and much faster); this commit also corrects the comments regarding Intel and Motorola endianness (Intel is little, Motorola is big)
|
Any particular reason this still hasn't been pulled in? It's approaching the 2 year mark... |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for floating point fields for both single and double precision. If you're avoiding waveform80's struct refactor for some reason, commit 2f0bcb7 was based on ianare's development, then merged with waveform80's branch, so you can still get the floating point functionality without waveform80's stuff. Not sure why you would, though.