Issue 1321: update amethyst.sample.yml include all defaults

[wley3337]

Update amethyst.sample.yml to include all the defaults and the text description of what they do

Issue 1321

[agoodshort]

Few comments/suggested changes to make this starter config file a bit more resilient

[agoodshort]

2 minor suggestion for better readability through an IDE

[wley3337]

@goodshort Sorry for the delay and thank you so much for the review! I tested out with my local and the " around the commands are definitely not needed ( outside the special characters ). Accepted all the suggestions. It's odd though there was only a single space on my local version for the comments rather than a tab space. I wonder why that looked like an indent 🤷

Let me know if you'd like me to squash and push back up :)

[agoodshort]

Works fine on my machine. File is now a lot more readable and well documented. Thanks @wley3337

[cowboy-bebug]

Some defaults such as select-*-layout are missing from default.amethyst 😃

[jabkoo]

+1 for @cowboy-bebug's suggestion. select-*-layout commands are not documented anywhere, so I would also like to see it mentioned in docs/configuration-files.md.

[wley3337]

Hi all!

Been a bit swamped between work and life. Going to try and sort out the select-*-layout stuff in the next few days and get this updated

[Indyandie]

@wley3337 please note that this bug (#1419) could affect some of the configs

[wley3337]

Hi all!

Thank you all for your comments and patience. @Indyandie I'm not sure how to handle the possible conflicts. I added a block comment at the top to help with troubleshooting. Other than that, the only thing I can think of is to comment out the default values that are in default.amethyst and add the comment on each of those lines.

Something like:

# Commented out to avoid conflicts with `default.amethyst`
# only uncomment if you're going to change the default value below
# Move to the next layout in the list
# cycle-layout:
#   mod: mod1
#   key: space

[ianyh]

I might want to make some tweaks to this. Is it possible to give me permissions to push to this branch?

[vicmunoz]

Thanks!
Only missing:

window-max-count	The max number of windows that may be visible on a screen at one time before additional windows are minimized. A value of 0 disables the feature. (default 0)

disable-screen-padding-on-inbuilt	true to disable screen padding on in-built display (default false).

and a typo, is mod2 in default
swap-screen-cw:
mod: mod2
key: l

[prettymuchbryce]

We should merge this. Even if it's incomplete it is already way better than the current sample file, and this PR has been open for nearly 6 months.

[wley3337]

Added the missing two defaults above and fixed typo

[wley3337]

Oh, @ianyh I think I granted you access to push/pull let me know if that didn't work :) I pulled right before addressing the two comments with no diff so not sure if Github let you know :)