Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force active ID cache regen on space change after adding windows #954

Merged
merged 2 commits into from
Feb 22, 2020

Conversation

ianyh
Copy link
Owner

@ianyh ianyh commented Feb 22, 2020

Closes #674

@ianyh ianyh merged commit 3fd9274 into development Feb 22, 2020
@ianyh ianyh deleted the fullscreen-transition branch February 22, 2020 01:36
@ianfixes
Copy link
Contributor

You should add some comments to Change.swift; I had been under the impression that this was something to do with event management, not cache management. There is some mystery (to me) to where & how we have to do this sort of thing, and I was really hesitant to touch any of that code for that reason.

I guess what I'm saying is that I wonder if any code that I contributed may have benefited from understanding the ID cache.

@ianyh
Copy link
Owner Author

ianyh commented Feb 24, 2020

The change to that enum is unrelated. I was just adding more meaningful values than unknown because it was hard to debug otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enter/Exit Full Screen causes Amethyst to brake arrangement of windows
2 participants