Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-8150: Added enabled attributes types configuration #123

Merged
merged 2 commits into from
Jul 17, 2024
Merged

IBX-8150: Added enabled attributes types configuration #123

merged 2 commits into from
Jul 17, 2024

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Jun 10, 2024

🎫 Issue IBX-8150

Description:

For QA:

Documentation:

@github-actions GitHub Actions
Copy link

Thanks for contribution! 🎉

To test the changes please execute:

composer config extra.symfony.endpoint https://api.github.com/repos/ibexa/recipes-dev/contents/index.json?ref=flex/pull-123

before executing the recipes.

@webhdx webhdx requested a review from a team June 12, 2024 07:55
@Steveb-p Steveb-p requested a review from a team June 12, 2024 08:03
@konradoboza konradoboza requested a review from a team June 12, 2024 08:05
@webhdx
Copy link
Contributor

webhdx commented Jul 9, 2024

@ViniTou Rebase is needed here.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@alongosz alongosz merged commit 3fd2560 into master Jul 17, 2024
2 checks passed
@alongosz alongosz deleted the ibx-8150-custom-tag-attr branch July 17, 2024 12:57
Steveb-p
Steveb-p reviewed Jul 30, 2024
View reviewed changes
ibexa/connector-qualifio/5.0/config/packages/ibexa_connector_qualifio.yaml
ibexa_fieldtype_richtext:
enabled_attribute_types:
- campaign
- measurement
Copy link
Contributor

@Steveb-p Steveb-p Jul 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is measurement enabled as part of ibexa_connector_qualifio.yaml package config @ViniTou ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steveb-p Steveb-p Steveb-p approved these changes

@webhdx webhdx webhdx approved these changes

@barbaragr barbaragr barbaragr approved these changes

@konradoboza konradoboza konradoboza approved these changes

Assignees
No one assigned
Labels
QA approved Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ViniTou @webhdx @Steveb-p @barbaragr @konradoboza @alongosz