Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-8356: Reworked JWT GraphQL firewall configuration to comply with Symfony-based authentication #124

Merged
merged 5 commits into from
Jul 1, 2024

Conversation

konradoboza
Copy link
Contributor

@konradoboza konradoboza commented Jun 13, 2024

🎫 Issue IBX-8356

Related PRs:

Description:

We rely on the Lexik\Bundle\JWTAuthenticationBundle\Security\Authenticator\JWTAuthenticator from now on according to the.

For QA:

Documentation:

As always for security-related changes - if we mention firewall configuration anywhere, we need to adjust according to this PR.

Copy link

Thanks for contribution! 🎉

To test the changes please execute:

composer config extra.symfony.endpoint https://api.github.com/repos/ibexa/recipes-dev/contents/index.json?ref=flex/pull-124

before executing the recipes.

@alongosz alongosz requested a review from a team June 19, 2024 09:38
@konradoboza konradoboza changed the title IBX-8356: Reworked JWT GraphQL firewall configuration to comply with Symfony-based authentication [WiP] IBX-8356: Reworked JWT GraphQL firewall configuration to comply with Symfony-based authentication Jun 24, 2024
@konradoboza konradoboza force-pushed the ibx-8356-removed-authenticatorinterface-graphql branch from a6ee64e to d311097 Compare June 25, 2024 13:11
@konradoboza konradoboza changed the title [WiP] IBX-8356: Reworked JWT GraphQL firewall configuration to comply with Symfony-based authentication IBX-8356: Reworked JWT GraphQL firewall configuration to comply with Symfony-based authentication Jun 25, 2024
@Steveb-p
Copy link
Contributor

🚜

@konradoboza
Copy link
Contributor Author

konradoboza commented Jun 27, 2024

It seems we were lacking config/packages/lexik_jwt_authentication.yaml in OSS and Headless editions whereas we have JWT GraphQL and REST there. It most likely was just an oversight. Ref: 59f6fb7.

@micszo micszo changed the title IBX-8356: Reworked JWT GraphQL firewall configuration to comply with Symfony-based authentication [TMP commit] IBX-8356: Reworked JWT GraphQL firewall configuration to comply with Symfony-based authentication Jun 27, 2024
@konradoboza konradoboza force-pushed the ibx-8356-removed-authenticatorinterface-graphql branch from 32f40ed to a4b2805 Compare June 27, 2024 09:07
Copy link

sonarcloud bot commented Jul 1, 2024

@micszo micszo changed the title [TMP commit] IBX-8356: Reworked JWT GraphQL firewall configuration to comply with Symfony-based authentication IBX-8356: Reworked JWT GraphQL firewall configuration to comply with Symfony-based authentication Jul 1, 2024
@micszo micszo removed their assignment Jul 1, 2024
@konradoboza konradoboza merged commit aa3a512 into master Jul 1, 2024
2 checks passed
@konradoboza konradoboza deleted the ibx-8356-removed-authenticatorinterface-graphql branch July 1, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Doc needed The changes require some documentation QA approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants