-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-8324: Reworked JWT editorial bearer in page builder #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for contribution! 🎉 To test the changes please execute:
before executing the recipes. |
konradoboza
changed the title
IBX-8324: Removed obsolete JWT editorial bearer from page builder
IBX-8324: Reworked JWT editorial bearer in page builder
Jul 25, 2024
konradoboza
force-pushed
the
ibx-8324-removed-page-builder-jwt
branch
from
July 25, 2024 11:28
359ef5f
to
fb9fded
Compare
konradoboza
added
Bug
Something isn't working
Ready for review
Doc needed
The changes require some documentation
labels
Jul 25, 2024
konradoboza
force-pushed
the
ibx-8324-removed-page-builder-jwt
branch
from
July 26, 2024 08:09
fb9fded
to
6c68aff
Compare
Steveb-p
reviewed
Jul 26, 2024
Quality Gate passedIssues Measures |
Steveb-p
approved these changes
Jul 26, 2024
tomaszszopinski
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA approved on IbexaDXP 5.0 commerce p.sh
ViniTou
approved these changes
Jul 29, 2024
adamwojs
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
Why on earth do we need yet another firewall? 😮💨We actually don't,custom_authenticators
fallback does the trick.Symfony\Component\Security\Core\Authentication\Provider\AnonymousAuthenticationProvider
was doing the job before it got deprecated. It means all the/_fragment
calls were caught andPermissionResolver::setCurrentUserPreference
was invoked so we were authenticated. Since we cannot rely on this mechanism anymore, I needed to figure out how to make sure we won't be having unauthenticated calls in page builder resulting in login screen redirection.Why not
EventSubscriber
?It just won't work - each call needs to go through built-in Symfony authenticator-based system whereas authentication providers are not to be relied upon anymore. Besides, we don't have any security-related events that are available for subrequests.
Why the original issue from the JIRA ticket emerges only on Varnish?
/_fragment
calls are strictly related to ESI calls (render_esi
Twig helpers for each Page Builder block) - if no reverse proxy is in use we fallback torender
and no separate calls are there.For QA:
Documentation:
Another
security.yaml
related change.