Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-8691: Simplified security config for OAuth2 server usages #135

Merged
merged 12 commits into from
Aug 21, 2024

Conversation

konradoboza
Copy link
Contributor

🎫 Issue IBX-8691

Related PRs:

Description:

It seems we can get rid of our security layer within ibexa/oauth2-server bundle. It comes with simplified firewall configuration as the whole authentication process can be done via 3rd party custom authenticator (League\Bundle\OAuth2ServerBundle\Security\Authenticator\OAuth2Authenticator) referenced just via oauth2: true key.

Putting that under our recently introduced ibexa_rest firewall is intentional - config is easier to read as we basically set up a fallback custom authenticator for OAuth2 server use-cases.

For QA:

Documentation:

It seems we can adjust the OAuth2 server documentation accordingly.

Copy link

github-actions bot commented Aug 9, 2024

Thanks for contribution! 🎉

To test the changes please execute:

composer config extra.symfony.endpoint https://api.github.com/repos/ibexa/recipes-dev/contents/index.json?ref=flex/pull-135

before executing the recipes.

@konradoboza konradoboza added the Doc needed The changes require some documentation label Aug 9, 2024
@konradoboza konradoboza requested review from a team and Nattfarinn August 9, 2024 10:46
@alongosz alongosz requested a review from a team August 9, 2024 10:54
ibexa/commerce/5.0/config/packages/security.yaml Outdated Show resolved Hide resolved
ibexa/experience/5.0/config/packages/security.yaml Outdated Show resolved Hide resolved
ibexa/headless/5.0/config/packages/security.yaml Outdated Show resolved Hide resolved
@konradoboza konradoboza force-pushed the ibx-8691-reworked-oauth2-server-security branch from 4de58ee to a4d961d Compare August 14, 2024 12:50
@micszo micszo force-pushed the ibx-8691-reworked-oauth2-server-security branch from e229418 to d45e618 Compare August 16, 2024 09:58
@micszo micszo force-pushed the ibx-8691-reworked-oauth2-server-security branch from 84fac46 to 67b93db Compare August 21, 2024 06:58
Copy link

sonarcloud bot commented Aug 21, 2024

@micszo micszo removed their assignment Aug 21, 2024
@konradoboza konradoboza merged commit 8b9ed28 into master Aug 21, 2024
2 checks passed
@konradoboza konradoboza deleted the ibx-8691-reworked-oauth2-server-security branch August 21, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Doc needed The changes require some documentation QA approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants