Wrong file icon for custom filetype #1497

nowaylifer · 2024-10-18T13:45:33Z

nowaylifer
Oct 18, 2024

I use 'mini.icons' and when modify filetype config as in the following example, the corresponding file's icon displayed incorrectly in fzf-lua window. Is there some workaround maybe?

vim.filetype.add({
  filename = {
    ["somefile"] = "lua",
  },
})

Answered by ibhagwan

Oct 23, 2024

#1498 (comment)

View full answer

ibhagwan · 2024-10-18T13:54:15Z

ibhagwan
Oct 18, 2024
Maintainer

I use 'mini.icons' and when modify filetype config as in the following example, the corresponding file's icon displayed incorrectly in fzf-lua window. Is there some workaround maybe?

For performance reasons fzf-lua caches the internal mappings in mini, can you try loading fzf-lua for the first time only after calling vim.filetype.add?

2 replies

nowaylifer Oct 18, 2024
Author

I use 'mini.icons' and when modify filetype config as in the following example, the corresponding file's icon displayed incorrectly in fzf-lua window. Is there some workaround maybe?

For performance reasons fzf-lua caches the internal mappings in mini, can you try loading fzf-lua for the first time only after calling vim.filetype.add?

Yes, I'm already lazy loading it with lazy.nvim

ibhagwan Oct 18, 2024
Maintainer

I use 'mini.icons' and when modify filetype config as in the following example, the corresponding file's icon displayed incorrectly in fzf-lua window. Is there some workaround maybe?

For performance reasons fzf-lua caches the internal mappings in mini, can you try loading fzf-lua for the first time only after calling vim.filetype.add?

Yes, I'm already lazy loading it with lazy.nvim

Alright I’ll check why this happens when I come back from my travel

#1498

dpetka2001 · 2024-10-22T22:28:36Z

dpetka2001
Oct 22, 2024

I notice something similar although not exactly the same. I have created a utility function to use for file browser-like experience (in an effort to get rid of other file explorer plugins, if it suits my needs after some time). The function is the following

function M.fzf_dirs(opts)
  local fzf = require("fzf-lua")
  local path = require("fzf-lua.path")
  -- require("fzf-lua.devicons").plugin_load("mini")
  local uv = vim.uv or vim.loop
  local cmd = "fd -d1"

  local function get_full_path(selected)
    if #selected < 1 then
      return
    end
    local entry = path.entry_to_file(selected[1], { cwd = uv.cwd() })
    if entry.path == "<none>" then
      return
    end
    -- Taken from require('fzf-lua').files, maybe there's a better way?
    local fullpath = entry.path or entry.uri and entry.uri:match("^%a+://(.*)")
    if not path.is_absolute(fullpath) then
      fullpath = path.join({ uv.cwd(), fullpath })
    end
    return fullpath
  end

  opts = opts or {}
  opts = {
    defaults = {},
    prompt = "Fzf Browser> " .. vim.fn.fnamemodify(uv.cwd(), ":~") .. "/",
    cwd = uv.cwd(),
    cwd_prompt_shorten_len = 32,
    cwd_prompt_shorten_val = 1,
    file_icons = true,
    fzf_opts = {
      ["--tiebreak"] = "end",
      ["--preview"] = {
        type = "cmd",
        fn = function(selected)
          local fullpath = get_full_path(selected)
          return string.format("command ls -Alhv --group-directories-first %s", fullpath)
        end,
      },
    },
    fn_transform = function(x)
      return fzf.make_entry.file(x, { file_icons = true, color_icons = true, cwd = uv.cwd() })
    end,
    actions = {
      ["default"] = {
        function(selected)
          local fullpath = get_full_path(selected)
          vim.cmd("cd " .. fullpath)
          -- fzf_lua.fzf_exec("fd -td", opts)
          opts.cwd = fullpath
          M.fzf_dirs()
        end,
      },
      ["alt-f"] = function(selected)
        local fullpath = get_full_path(selected)
        if uv.fs_stat(fullpath).type ~= "directory" then
          fullpath = vim.fn.fnamemodify(fullpath, ":p:h") .. "/"
        end
        vim.ui.input({ prompt = "File Name: " }, function(name)
          if name == nil then
            return
          end
          vim.cmd("e " .. fullpath .. name)
          vim.cmd("w ++p") -- will create directory if not exists, so you can write new/dir/some_file.lua
        end)
      end,
      ["alt-g"] = {
        function(selected)
          local cwd = selected[1] --[[@as string]]
          local parent = require("fzf-lua.path").parent(cwd, false)
          vim.cmd("cd ..")
          opts.cwd = parent
          M.fzf_dirs()
        end,
      },
    },
  }
  fzf.fzf_exec(cmd, opts)
end

I use LazyVim distro for my Neovim setup. I've observed the following:

When I press <leader>fc to invoke my custom function then I get no filetype icons. I get icons for init.lua and `README.MD and directories icons but not for simple files
If I first open find_files then I have icons for everything. If I invoke my function and navigate to a folder that has Lua files, then I get no icons. When I open find_files again there are no icons this time, although the first time I opened it there were icons. When I open buffers I get no icons as well.
If I first open buffers then I have icons. I open my custom function and it also has icons. I open find_files and it also has icons.

From scourging through the code (although I'm not comfortable with the codebase and struggle a lot understanding), my guess is that buffers provider has a make_entry.file in which it doesn't load icons yet and later on constructs the entry with the buficon.

So, if I open buffers first it caches the icons for the entry and then everything else also works normally? But if I open my custom function which also has a make_entry.file (with file_icons = true in contrast with what happens in buffers provider), then this for some reason doesn't load the icons and that stays cached and also affects the other pickers as well?

LazyVim also uses mini.icons by default and I disabled them and enabled nvim-web-devicons in my personal configuration and can confirm that it doesn't happen then. It only happens with mini.icons.

Am I maybe not using the make_entry.file correctly in my custom function? If so, I'd appreciate some pointer as to how I can overcome this. For now I just first open buffers, so that everything works fine afterwards. Or if something else is amiss with mini.icons with regards to fzf-lua, I'll wait for an appropriate solution.

PS: If I do =require("fzf-lua.devicons").state() then lua extension has the default_icon. Actually, there are 2 entries, one with the correct icon and one with the default icon. I'm guessing the entry with the default icon comes from my custom function and it appears before the entry with the correct icon, so that's why it returns the default icon instead of the normal one??

15 replies

ibhagwan Oct 31, 2024
Maintainer

By the way I also tried the header option like you said, but didn't work for me, so I just defined the headers in fzf_opts["--header"] instead and works perfectly fine.

It should work, lmk if you want I can take a look at your code and see what’s wrong with the opt.

dpetka2001 Oct 31, 2024

Sure, this is the code of the custom function at the moment

function M.fzf_dirs(opts)
  local fzf = require("fzf-lua")
  local config = require("fzf-lua.config")
  local path = require("fzf-lua.path")
  local uv = vim.uv or vim.loop
  local utils = require("fzf-lua.utils")
  local cmd = "fd -d1"

  local function hl_validate(hl)
    return not utils.is_hl_cleared(hl) and hl or nil
  end

  local function ansi_from_hl(hl, s)
    return utils.ansi_from_hl(hl_validate(hl), s)
  end

  local function get_full_path(selected)
    if #selected < 1 then
      return
    end
    local entry = path.entry_to_file(selected[1], { cwd = uv.cwd() })
    if entry.path == "<none>" then
      return
    end
    -- Taken from require('fzf-lua').files, maybe there's a better way?
    local fullpath = entry.path or entry.uri and entry.uri:match("^%a+://(.*)")
    if not path.is_absolute(fullpath) then
      fullpath = path.join({ uv.cwd(), fullpath })
    end
    return fullpath
  end

  opts = opts or {}
  opts = {
    defaults = {},
    prompt = "Fzf Browser> " .. vim.fn.fnamemodify(uv.cwd(), ":~") .. "/",
    cwd = uv.cwd(),
    cwd_prompt_shorten_len = 32,
    cwd_prompt_shorten_val = 1,
    file_icons = true,
    fzf_opts = {
      ["--tiebreak"] = "end",
      ["--preview"] = {
        type = "cmd",
        fn = function(selected)
          local fullpath = get_full_path(selected)
          return string.format("command ls -Alhv --group-directories-first %s", fullpath)
        end,
      },
      -- ["--header"] = string.format(
      --   ":: <%s> to %s | <%s> to %s | <%s> to %s",
      --   ansi_from_hl("FzfLuaHeaderBind", "enter"),
      --   ansi_from_hl("FzfLuaHeaderText", "enter directory"),
      --   ansi_from_hl("FzfLuaHeaderBind", "alt-f"),
      --   ansi_from_hl("FzfLuaHeaderText", "create file"),
      --   ansi_from_hl("FzfLuaHeaderBind", "alt-g"),
      --   ansi_from_hl("FzfLuaHeaderText", "parent directory")
      -- ),
    },
    fn_transform = function(x)
      return fzf.make_entry.file(x, { file_icons = true, color_icons = true, cwd = uv.cwd() })
    end,
    actions = {
      ["enter"] = {
        fn = function(selected)
          local fullpath = get_full_path(selected)
          vim.cmd("tcd " .. fullpath)
          -- fzf_lua.fzf_exec("fd -td", opts)
          opts.cwd = fullpath
          M.fzf_dirs(opts)
        end,
        desc = "enter_directory",
        header = "test",
      },
      ["alt-f"] = function(selected)
        local fullpath = get_full_path(selected) --[[@as string]]
        if uv.fs_stat(fullpath).type ~= "directory" then
          fullpath = vim.fn.fnamemodify(fullpath, ":p:h") .. "/"
        end
        vim.ui.input({ prompt = "File Name: " }, function(name)
          if name == nil then
            return
          end
          vim.cmd("e " .. fullpath .. name)
          vim.cmd("w ++p") -- will create directory if not exists, so you can write new/dir/some_file.lua
        end)
      end,
      ["alt-g"] = {
        function(selected)
          local cwd = selected[1] --[[@as string]]
          local parent = require("fzf-lua.path").parent(cwd, false)
          vim.cmd("cd ..")
          opts.cwd = parent
          M.fzf_dirs(opts)
        end,
        desc = "parent_directory",
      },
    },
  }
  config.set_action_helpstr(opts.actions["alt-f"], "create_file")
  fzf.fzf_exec(cmd, opts)
end

and I just call it via a mapping with lazy.nvim keys as following

keys = {
      {
        "<leader>fc",
        Util.fzf.fzf_dirs,
        desc = "Fzf Browser",
      },
}

ibhagwan Nov 1, 2024
Maintainer

Here you go @dpetka2001, slightly better UX using fzf's native reload so the process doesn't restart when you enter|alt-g, this also fixes the header issue as I forgot the headers are only activated when calling opts = core.set_header(opts, { "actions", "cwd" }):

function M.fzf_dirs(opts)
  local fzf = require("fzf-lua")
  local core = fzf.core
  local path = fzf.path
  local utils = fzf.utils
  local config = fzf.config
  local shell = require("fzf-lua.shell")
  local uv = vim.uv or vim.loop

  local function hl_validate(hl)
    return not utils.is_hl_cleared(hl) and hl or nil
  end

  local function ansi_from_hl(hl, s)
    return utils.ansi_from_hl(hl_validate(hl), s)
  end

  local function get_full_path(selected)
    if #selected < 1 then
      return
    end
    local entry = path.entry_to_file(selected[1], { cwd = uv.cwd() })
    if entry.path == "<none>" then
      return
    end
    -- Taken from require('fzf-lua').files, maybe there's a better way?
    local fullpath = entry.path or entry.uri and entry.uri:match("^%a+://(.*)")
    if not path.is_absolute(fullpath) then
      fullpath = path.join({ uv.cwd(), fullpath })
    end
    return fullpath
  end

  opts = config.normalize_opts({
    defaults = {},
    cmd = "fd -d1",
    prompt = "Fzf Browser> " .. vim.fn.fnamemodify(uv.cwd(), ":~") .. "/",
    cwd = uv.cwd(),
    cwd_prompt_shorten_len = 32,
    cwd_prompt_shorten_val = 1,
    file_icons = true,
    fzf_opts = {
      ["--tiebreak"] = "end",
      ["--preview"] = {
        type = "cmd",
        fn = function(selected)
          local fullpath = get_full_path(selected)
          return string.format("command ls -Alhv --group-directories-first %s", fullpath)
        end,
      },
      -- ["--header"] = string.format(
      --   ":: <%s> to %s | <%s> to %s | <%s> to %s",
      --   ansi_from_hl("FzfLuaHeaderBind", "enter"),
      --   ansi_from_hl("FzfLuaHeaderText", "enter directory"),
      --   ansi_from_hl("FzfLuaHeaderBind", "alt-f"),
      --   ansi_from_hl("FzfLuaHeaderText", "create file"),
      --   ansi_from_hl("FzfLuaHeaderBind", "alt-g"),
      --   ansi_from_hl("FzfLuaHeaderText", "parent directory")
      -- ),
    },
    __fn_transform = function(x)
      return fzf.make_entry.file(x, { file_icons = true, color_icons = true, cwd = uv.cwd() })
    end,
    __fn_reload = function(_)
      return opts.cmd
    end,
    actions = {
      ["enter"] = {
        fn = function(selected)
          local fullpath = get_full_path(selected)
          vim.cmd("tcd " .. fullpath)
          -- fzf_lua.fzf_exec("fd -td", opts)
          opts.cwd = fullpath
          M.fzf_dirs(opts)
        end,
        desc = "enter_directory",
        header = "CD",
        reload = true,
      },
      ["alt-f"] = {
        fn = function(selected)
          local fullpath = get_full_path(selected) --[[@as string]]
          if uv.fs_stat(fullpath).type ~= "directory" then
            fullpath = vim.fn.fnamemodify(fullpath, ":p:h") .. "/"
          end
          vim.ui.input({ prompt = "File Name: " }, function(name)
            if name == nil then
              return
            end
            vim.cmd("e " .. fullpath .. name)
            vim.cmd("w ++p") -- will create directory if not exists, so you can write new/dir/some_file.lua
          end)
        end,
        desc = "create_file",
      },
      ["alt-g"] = {
        fn = function(selected)
          local cwd = selected[1] --[[@as string]]
          local parent = require("fzf-lua.path").parent(cwd, false)
          vim.cmd("cd ..")
          opts.cwd = parent
          M.fzf_dirs(opts)
        end,
        desc = "parent_directory",
        header = "Goto Parent",
        reload = true,
      },
    },
  }, {})

  -- build the "reload" cmd and remove '-- {+}' from the initial cmd
  local reload, id = shell.reload_action_cmd(opts, "{+}")
  local contents = reload:gsub("%-%-%s+{%+}$", "")
  opts.__reload_cmd = reload

  opts._fn_pre_fzf = function()
    shell.set_protected(id)
  end

  opts = core.set_header(opts, { "actions", "cwd" })
  return fzf.fzf_exec(contents, opts)
end

dpetka2001 Nov 1, 2024

Thank you very much. I'll definitely try this out and copy it in the util file. Not sure if I completely switch to this, because I'd prefer I understand what's going on. I have to improve my Lua knowledge and also get into FzfLua's codebase more in depth (at least in the amount possible by my current knowledge in programming, since I just started as a hobbyist at the start of this year).

Again, really appreciate you taking time to interact with me. You've always been helpful and provided insight even in past issues/discussions that I created. Thank you!!!

ibhagwan Nov 1, 2024
Maintainer

Again, really appreciate you taking time to interact with me. You've always been helpful and provided insight even in past issues/discussions that I created. Thank you!!!

Ty for the kinds words @dpetka2001!

ibhagwan · 2024-10-23T11:48:53Z

ibhagwan
Oct 23, 2024
Maintainer

#1498 (comment)

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Wrong file icon for custom filetype #1497

{{title}}

Replies: 3 comments 17 replies

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{title}}

Select a reply

Wrong file icon for custom filetype #1497

nowaylifer Oct 18, 2024

Replies: 3 comments · 17 replies

ibhagwan Oct 18, 2024 Maintainer

nowaylifer Oct 18, 2024 Author

ibhagwan Oct 18, 2024 Maintainer

dpetka2001 Oct 22, 2024

ibhagwan Oct 31, 2024 Maintainer

dpetka2001 Oct 31, 2024

ibhagwan Nov 1, 2024 Maintainer

dpetka2001 Nov 1, 2024

ibhagwan Nov 1, 2024 Maintainer

ibhagwan Oct 23, 2024 Maintainer

nowaylifer
Oct 18, 2024

Replies: 3 comments 17 replies

ibhagwan
Oct 18, 2024
Maintainer

nowaylifer Oct 18, 2024
Author

ibhagwan Oct 18, 2024
Maintainer

dpetka2001
Oct 22, 2024

ibhagwan Oct 31, 2024
Maintainer

ibhagwan Nov 1, 2024
Maintainer

ibhagwan Nov 1, 2024
Maintainer

ibhagwan
Oct 23, 2024
Maintainer